Force sending JSON if accept header is requesting it #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well for now I think that this simple piece of code will do it. I don't think we're at the stage where we'll handle more than JSON and HTML |
|
The Hammer says it's good. |
louismunro
added a commit
that referenced
this pull request
Jun 29, 2015
Force sending JSON if accept header is requesting it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a client is explicitally requesting JSON through the Accept header, we should enforce that since it it removes code duplication by creating new actions just for that
Impacts
Shouldn't be any for existing code.
Delete branch after merge
NO (required for cloud)
NEWS file entries
Enhancements