Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RADIUS audit log entry in correct tenant when switches are defined by MAC address #6690

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

nqb
Copy link
Contributor

@nqb nqb commented Nov 9, 2021

Description

Add RADIUS audit log entry in correct tenant when switches are defined by MAC address

Impacts

FreeRADIUS tenant management

Issue

fixes #6540

Delete branch after merge

YES

NEWS file entries

Bug Fixes

  • Add RADIUS audit log entry in correct tenant when switches are defined by MAC address

@nqb
Copy link
Contributor Author

nqb commented Nov 26, 2021

@fdurand, I'm not able to test this fix correctly because it looks like radius_nas table is not updated after I add a new switch or if I send a RADIUS request coming from that switch.
I'm investigating.

@nqb nqb changed the title check if a network device is defined by MAC address Add RADIUS audit log entry in correct tenant when switches are defined by MAC address Nov 26, 2021
@nqb
Copy link
Contributor Author

nqb commented Nov 26, 2021

EDIT: my previous test was incorrect.

I was able to test it and it works as expected when switch are defined by IP address or by MAC address.

@nqb nqb merged commit 5af94ae into devel Nov 26, 2021
@nqb nqb deleted the fix/6540 branch November 26, 2021 09:06
nqb added a commit that referenced this pull request Nov 26, 2021
nqb added a commit that referenced this pull request Nov 26, 2021
nqb added a commit that referenced this pull request Nov 26, 2021
nqb added a commit that referenced this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

packetfence-set-tenant-id ignores switchs defined by MAC address
1 participant