Feature/ldap explorer back end #7634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VakarisZ
commented
Apr 24, 2023
| @@ -0,0 +1,122 @@ | |||
| package pfldapexplorer | |||
There was a problem hiding this comment.
Should be a different package?
VakarisZ
commented
Apr 24, 2023
| } | ||
|
|
||
| func connect(ldapServer *ldapServer, timeout time.Duration) *ldap.Conn { | ||
| ldap.DefaultTimeout = timeout |
There was a problem hiding this comment.
TODO: Check if this alters the timeout just for this call or for the whole project/service running this
VakarisZ
commented
Apr 24, 2023
go/caddy/pfldapexplorer/sample.md
Outdated
Comment on lines
1
to
4
| # Search | ||
|
|
||
| ``` | ||
| curl -H "Content-Type: application/json" -d '{"server":"AD","search":"(sAMAccountName=zammit)","attributes":["userPrincipalName","sAMAccountName"]}' http://127.0.0.1:22226/api/v1/ldap/search| python -m json.tool |
|
Still in draft but there 2 things needs to be done:
|
VakarisZ
commented
Apr 27, 2023
| if h.Router.Match(chiCtx, r.Method, r.URL.Path) { | ||
| h.Router.ServeHTTP(w, r) | ||
|
|
||
| // TODO change me and wrap actions into something that handles server errors |
There was a problem hiding this comment.
what does this mean?
jrouzierinverse
requested changes
Apr 27, 2023
fdurand
reviewed
Apr 28, 2023
| @@ -0,0 +1,8 @@ | |||
| :22226 { | |||
| bind 127.0.0.1 | |||
There was a problem hiding this comment.
When contenerized it will need need to bind on *
VakarisZ
force-pushed
the
feature/ldap_explorer_back_end
branch
2 times, most recently
from
252f9aa
to
3655283
Compare
VakarisZ
force-pushed
the
feature/ldap_explorer_back_end
branch
from
3655283
to
3367938
Compare
VakarisZ
force-pushed
the
feature/ldap_explorer_back_end
branch
from
52977e9
to
3b431dd
Compare
VakarisZ
force-pushed
the
feature/ldap_explorer_back_end
branch
from
ad3f13e
to
60c05c8
Compare
satkunas
requested changes
Jun 28, 2023
Fix UT according to ldap back end changes
VakarisZ
force-pushed
the
feature/ldap_explorer_back_end
branch
from
c701572
to
81e8d93
Compare
nqb
added a commit
that referenced
this pull request
Jul 6, 2023
nqb
added a commit
that referenced
this pull request
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a service that allows ldap search
Adds an ldap search client that services can use to perform any ldap search
Impacts
Only back-end. Front-end changes will come in a separate PR.
Code / PR Dependencies
Based on this branch by @fdurand
NEW Package(s) required
Ginkgo and gomega for people who want to run the tests
Issue
(OPTIONAL. REMOVE IF NOT NEEDED)
The following syntax 'fixes #ISSUE_NUMBER' will automatically closes a Github issue on pull-request merge time.
Modify the ISSUE_NUMBER in order to reflect the Github issue that need to be closed
fixes #ISSUE_NUMBER
Delete branch after merge
YES
Checklist