Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/remove-symantec-provisioner #7700

Merged
merged 2 commits into from Jun 16, 2023
Merged

Conversation

jrouzierinverse
Copy link
Member

Description

Remove Symantec Provisioner

Delete branch after merge

YES

NEWS file entries

Enhancements

  • Remove Symantec Provisioner

@@ -138,7 +138,7 @@ passthroughs=
# fencing.proxy_passthroughs
#
# Comma-delimited list of domains to be use for apache passthrough
proxy_passthroughs=crl.geotrust.com,ocsp.geotrust.com,crl.thawte.com,ocsp.thawte.com,crl.comodoca.com,ocsp.comodoca.com,crl.incommon.org,ocsp.incommon.org,crl.usertrust.com,ocsp.usertrust.com,mscrl.microsoft.com,crl.microsoft.com,ocsp.apple.com,ocsp.digicert.com,ocsp.entrust.com,srvintl-crl.verisign.com,ocsp.verisign.com,ctldl.windowsupdate.com,crl.globalsign.net,pki.google.com,www.microsoft.com,crl.godaddy.com,ocsp.godaddy.com,certificates.godaddy.com,crl.globalsign.com,secure.globalsign.com,cacerts.digicert.com,crt.comodoca.com,crl.incommon-rsa.org,crl.quovadisglobal.com,cert.incommon.org,crt.usertrust.com,crl.verisign.com,crl.starfieldtech.com,developer.apple.com,ts-crl.ws.symantec.com,certificates.intel.com,ocsp.sectigo.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to symantec provisionner i think

@@ -60,7 +60,7 @@ $t->options_ok("$base_url/advanced")
$t->options_ok("$base_url/fencing")
->status_is(200)
->json_is('/meta/proxy_passthroughs/placeholder', undef)
->json_is('/meta/proxy_passthroughs/implied', 'crl.geotrust.com,ocsp.geotrust.com,crl.thawte.com,ocsp.thawte.com,crl.comodoca.com,ocsp.comodoca.com,crl.incommon.org,ocsp.incommon.org,crl.usertrust.com,ocsp.usertrust.com,mscrl.microsoft.com,crl.microsoft.com,ocsp.apple.com,ocsp.digicert.com,ocsp.entrust.com,srvintl-crl.verisign.com,ocsp.verisign.com,ctldl.windowsupdate.com,crl.globalsign.net,pki.google.com,www.microsoft.com,crl.godaddy.com,ocsp.godaddy.com,certificates.godaddy.com,crl.globalsign.com,secure.globalsign.com,cacerts.digicert.com,crt.comodoca.com,crl.incommon-rsa.org,crl.quovadisglobal.com,cert.incommon.org,crt.usertrust.com,crl.verisign.com,crl.starfieldtech.com,developer.apple.com,ts-crl.ws.symantec.com,certificates.intel.com,ocsp.sectigo.com');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to symantec provisionner i think

@fdurand
Copy link
Member

fdurand commented Jun 12, 2023

We should have a upgrade script that remove or comment the symantec provisionner in the config

@jrouzierinverse
Copy link
Member Author

We should have a upgrade script that remove or comment the symantec provisionner in the config

It is here.
addons/upgrade/to-13.0-remove-provisioner.pl

@satkunas satkunas self-requested a review June 13, 2023 14:58
Copy link
Contributor

@satkunas satkunas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI changes look good.

@fdurand
Copy link
Member

fdurand commented Jun 14, 2023

rebase and it will be merged

@jrouzierinverse jrouzierinverse force-pushed the feature/remove-symantec-provisioner branch from 236e515 to a4bb6a0 Compare June 14, 2023 12:47
@jrouzierinverse
Copy link
Member Author

rebase and it will be merged

done

Copy link
Contributor

@nqb nqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is documentation to remove under docs

@nqb
Copy link
Contributor

nqb commented Jun 16, 2023

I'm wrong, it's already done #7692

@nqb nqb merged commit 19b94e8 into devel Jun 16, 2023
1 check passed
@nqb nqb deleted the feature/remove-symantec-provisioner branch June 16, 2023 08:13
nqb added a commit that referenced this pull request Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants