Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split in 2 the search on usernameattribute value #8000

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

fdurand
Copy link
Member

@fdurand fdurand commented Feb 5, 2024

Description

Adapt the ldap search filter in freeradius to do the sAMAccountName lookup

(&(|(UserPrincipalName=bbuny@acme.com)(UserPrincipalName=bbuny)(sAMAccountName=bbuny))) -> (&(|(UserPrincipalName=bbuny@acme.com)(UserPrincipalName=bbuny)(sAMAccountName=bbuny)(sAMAccountName=bbuny@acme.com)))

Impacts

  • RADIUS authorize workflow

Code / PR Dependencies

Delete branch after merge

YES

Checklist

  • Document the feature
  • Add OpenAPI specification
  • Add unit tests
  • Add acceptance tests (TestLink)

NEWS file entries

Enhancements

  • Adap the ldap search filter in Freeradius to do the sAMAccountName lookup

Copy link
Member

@jrouzierinverse jrouzierinverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. How was it tested?

@satkunas
Copy link
Contributor

satkunas commented Apr 2, 2024

@fdurand please test and merge if OK

@fdurand
Copy link
Member Author

fdurand commented Apr 2, 2024

Tested and works correctly

(18) Tue Apr  2 14:28:39 2024: Debug: Inverseinc: Performing search in "dc=inverse,dc=inc" with filter "(&(|(servicePrincipalName=0298903959)(servicePrincipalName=0298903959)(UserPrincipalName=0298903959)(UserPrincipalName=0298903959)(telephoneNumber=0298903959)(telephoneNumber=029
8903959)(sAMAccountName=0298903959)(sAMAccountName=0298903959)))", scope "sub"                                                                                                                                                                                                            
(18) Tue Apr  2 14:28:39 2024: Debug: Inverseinc: Waiting for search result...                                                                                                                                                                                                            
(18) Tue Apr  2 14:28:39 2024: Debug: Inverseinc: User object found at DN "CN=Jeanne Testor,OU=test_users,DC=inverse,DC=inc"

@fdurand fdurand merged commit 86cae73 into devel Apr 2, 2024
13 checks passed
fdurand added a commit that referenced this pull request Apr 2, 2024
@satkunas satkunas deleted the fix/radius_ldap_search_filter branch May 15, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants