Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Remove-Merge outdated switch module #8027

Merged
merged 5 commits into from
Apr 3, 2024

Conversation

abprasa
Copy link
Contributor

@abprasa abprasa commented Feb 22, 2024

Description

The existing code has a list of switch modules defined based on the switch series, this new code removes/merges such existing outdated switch modules.

Impacts

Making it switch type list clean in the UI and suitable for users to choose modules based on the version of the switch instead of the series.


NEW Package(s) required

No additional packages are needed.

Feature

This new code removes/merges the existing outdated switch modules defined based on the switch series, making it switch type list in UI clean and for a better user experience.

Delete branch after the merge

YES

Checklist

  • Document the feature In the Network Device Config Guide
  • Migration Script
  • Test the new modules on UI

NEWS file entries

New Features

  • Removing/Merging existing switch model defined based on switch series for the next release

@abprasa abprasa added this to the PacketFence-13.2 milestone Feb 22, 2024
@abprasa abprasa assigned fdurand and unassigned fdurand Feb 22, 2024
@abprasa abprasa requested a review from fdurand February 22, 2024 16:43
@fdurand
Copy link
Member

fdurand commented Mar 5, 2024

There is still references of the cisco switches you remove in constants/switch_acls.pm

@abprasa
Copy link
Contributor Author

abprasa commented Mar 12, 2024

There is still references of the cisco switches you remove in constants/switch_acls.pm
Removed the references

@fdurand
Copy link
Member

fdurand commented Mar 14, 2024

It miss the upgrade script in order to rename the switch module in the switches.conf (the one defined in use base)

@abprasa
Copy link
Contributor Author

abprasa commented Mar 24, 2024

It miss the upgrade script in order to rename the switch module in the switches.conf (the one defined in use base)

Created and updated the script

addons/upgrade/to-13.2-convert-switch-types.pl Outdated Show resolved Hide resolved
addons/upgrade/to-13.2-convert-switch-types.pl Outdated Show resolved Hide resolved
addons/upgrade/to-13.2-convert-switch-types.pl Outdated Show resolved Hide resolved
@abprasa abprasa force-pushed the feature/remove-outdated_switch_modules branch from 8236dc7 to 20db8ec Compare April 3, 2024 16:46
@abprasa abprasa merged commit 64438d0 into devel Apr 3, 2024
13 checks passed
@satkunas satkunas deleted the feature/remove-outdated_switch_modules branch May 15, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants