Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/provisioner_rework #8033

Merged
merged 85 commits into from
Apr 17, 2024
Merged

feature/provisioner_rework #8033

merged 85 commits into from
Apr 17, 2024

Conversation

jrouzierinverse
Copy link
Member

Description

Provide greater flexibility to provisioning workflow by adding filtering and actions.

Impacts

Provisioning workflow

Issue

fixes #7597

Delete branch after merge

YES

Checklist

(REQUIRED) - [yes, no or n/a]

  • Document the feature
  • [*] Add OpenAPI specification
  • Add unit tests
  • Add acceptance tests (TestLink)

NEWS file entries

Enhancements

  • Provide greater flexibility to provisioning workflow by adding filtering and actions.

@jrouzierinverse jrouzierinverse added this to the PacketFence-13.2 milestone Mar 11, 2024
@jrouzierinverse jrouzierinverse marked this pull request as ready for review April 1, 2024 19:03
fdurand
fdurand reviewed Apr 2, 2024
View reviewed changes
addons/dev-helpers/bin/provisioning_filters_flatten.pl Outdated Show resolved Hide resolved
addons/dev-helpers/bin/provisioning_filters_flatten.pl Outdated Show resolved Hide resolved
docs/api/spec/components/schemas/configdomain.yaml Outdated Show resolved Hide resolved
docs/api/spec/components/schemas/configsourcesubtypesponsoremail.yaml Outdated Show resolved Hide resolved
docs/api/spec/openapi.json Outdated Show resolved Hide resolved
html/pfappserver/lib/pfappserver/Form/Config/Provisioning.pm Outdated Show resolved Hide resolved
lib/pf/ConfigStore/ProvisioningFilters.pm Outdated Show resolved Hide resolved
lib/pf/UnifiedApi/Controller/Config/FilterEngines/ProvisioningFilters.pm Outdated Show resolved Hide resolved
@jrouzierinverse
Don't call authorize_enforce multitimes
553098d
@jrouzierinverse
Created provisioner scopes
d2123f2
@jrouzierinverse
Add rules
9e9be19
@jrouzierinverse
The implement matchRules
c09ec5c
@jrouzierinverse
Add match rules
25527e6
@jrouzierinverse
Only use the rules that exist for the scope.
eb058b8
@jrouzierinverse
Refactor to use getAnswerForScope
c2e13da
@jrouzierinverse
Add test for no rules
061b3d1
@jrouzierinverse
Scope node attribute by node_info
42f97af
@jrouzierinverse
Return getAnswerForScope if there are no rules
d7e9df4
@jrouzierinverse
move all the provisioner tests to t/unittest/provisioner.t
237cbea
@jrouzierinverse
Use pf::access_filter::provisioner
effa2af
@jrouzierinverse
Use pf::access_filter::provisioner for dispatching actions
80f88e2
@jrouzierinverse
Add a simple provisioner for testing
729d61e
@jrouzierinverse
Have kandji use authorize_enforce scope
fac1c02
@jrouzierinverse
remove provisioner.t
bc1623f
@jrouzierinverse
Add KANDJI_FIELDS
fd18e06
@jrouzierinverse
rename
03e1527
@jrouzierinverse
Allow empty values
bcfab01
@jrouzierinverse
Add a new route for Config::FilterEngines::ProvisioningFilters
827ed52
@jrouzierinverse
Add endpoint
eff8a30
@jrouzierinverse
Refactor a common form
164b45c
@jrouzierinverse
Refactor all to use pfappserver::Form::Config::FilterEngines::Provisi…
32941f4 
…oningFilter
@jrouzierinverse
remove unused variables
b56af24
@jrouzierinverse
remove unused file
7f82091
@jrouzierinverse
update .gitignore
aeac89c
@jrouzierinverse
Add jamf fields
5119663
@jrouzierinverse
Add all the filters
15112f1
@jrouzierinverse
use device with jamf
8c89f8b
@jrouzierinverse
handleAuthorizeEnforce for mobileiron
e142148
@jrouzierinverse
Add tool to help create a flatten view json docs for provisioning_fil…
32a6f59 
…ters
@jrouzierinverse
Add airwatch
e9b6183
@jrouzierinverse
add fields to provisioning_filters_meta_config_default_file
f963e4b
@jrouzierinverse
cleanup files
387be09
@jrouzierinverse
fix typo
ee7ee42
@jrouzierinverse
Fill out rules
8922b07
@jrouzierinverse
Add rules to the provisioning forms
c46364b
@jrouzierinverse
Add compliant_check fields
1fae6db
@jrouzierinverse
Pass in return value on empty
5c2156e
@jrouzierinverse
Handle the case where the complaince check failed
ba288ca
@jrouzierinverse
Add example file for meta
65e7fcb
@jrouzierinverse
Add new config files to packaging
b4f9308
@jrouzierinverse
Update openapi docs
802ccff
@jrouzierinverse
Update copyright
48b0775
@jrouzierinverse
Cleanup code
13c45d8
@jrouzierinverse
Update help
9bc0de7
@jrouzierinverse
Add support for jamfCloud
8f87b0a
@jrouzierinverse
Update openapi
e9accbf
@fdurand fdurand merged commit 6975a2e into devel Apr 17, 2024
13 checks passed
fdurand added a commit that referenced this pull request Apr 17, 2024
@fdurand
Updated NEWS.asciidoc for PR #8033
8c2f3f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdurand fdurand fdurand left review comments

@satkunas satkunas satkunas left review comments

Assignees

@fdurand fdurand

Labels
Type: Feature / Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autoregistration with a provisionner doesn't work as expected
3 participants
@jrouzierinverse @fdurand @satkunas