Fixes logic when pfacct and radius-acct are enabled #8175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdurand
force-pushed
the
fix/pfacct_radiusacct
branch
from
d5069e6
to
84ddb2f
Compare
JeGoi
reviewed
Aug 8, 2024
| my $vars = { | ||
| env_dict => { | ||
| PFACCT_ADDRESS=> "$port", | ||
| PFACCT_ADDRESS=> "$listeningIp:$port", |
There was a problem hiding this comment.
Is the "$port" = ":$port" when $listeningIp = ""?
For me, PFACCT_ADDRESS=:1833 is now different then the previous results
There was a problem hiding this comment.
the " : " should be added to $listeningIp when not empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the logic in order to run pfacct and radiusd-acct if all are enabled together
Impacts
Radius accounting
Delete branch after merge
YES
NEWS file entries
Bug Fixes