Stage 9 of clang compiler warning patches. #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extrafu
added a commit
that referenced
this pull request
Nov 4, 2015
Stage 9 of clang compiler warning patches.
the-nic
added a commit
to the-nic/sope
that referenced
this pull request
May 11, 2020
Implement support for SMTPS. Remove some unused initialization functions and add one expecting NSURL. From this url we can extract the scheme: smtp:// or smtps://, whereas the former is unencrypted SMTP and the latter refers to smtp in SSL/TLS wrapper mode (usually port 465). As with IMAPS and STARTTLS for sieve, openssl or GnuTLS need to be present for this to work. Fixes Alinto#31
the-nic
added a commit
to the-nic/sope
that referenced
this pull request
May 11, 2020
Following the implementations on IMAP and Sieve, implement STARTTLS also for SMTP: A new TLS socket is built on the already open socket which performs all TLS related actions. The SMTP client then only has to talk on the TLS socket. Note that after issuing STARTTLS command, we have to re-request the supported server capabilities (i.e. send EHLO again and parse the server response), because the announced AUTH mechanism may change. Fixes Alinto#31
the-nic
added a commit
to the-nic/sope
that referenced
this pull request
May 11, 2020
Implement support for SMTPS. Remove some unused initialization functions and add one expecting NSURL. From this url we can extract the scheme: smtp:// or smtps://, whereas the former is unencrypted SMTP and the latter refers to smtp in SSL/TLS wrapper mode (usually port 465). As with IMAPS and STARTTLS for sieve, openssl or GnuTLS need to be present for this to work. Fixes Alinto#31
the-nic
added a commit
to the-nic/sope
that referenced
this pull request
May 11, 2020
Following the implementations on IMAP and Sieve, implement STARTTLS also for SMTP: A new TLS socket is built on the already open socket which performs all TLS related actions. The SMTP client then only has to talk on the TLS socket. Note that after issuing STARTTLS command, we have to re-request the supported server capabilities (i.e. send EHLO again and parse the server response), because the announced AUTH mechanism may change. Fixes Alinto#31
the-nic
added a commit
to the-nic/sope
that referenced
this pull request
May 12, 2020
Implement support for SMTPS. Remove some unused initialization functions and add one expecting NSURL. From this url we can extract the scheme: smtp:// or smtps://, whereas the former is unencrypted SMTP and the latter refers to smtp in SSL/TLS wrapper mode (usually port 465). As with IMAPS and STARTTLS for sieve, openssl or GnuTLS need to be present for this to work. Fixes Alinto#31
the-nic
added a commit
to the-nic/sope
that referenced
this pull request
May 12, 2020
Following the implementations on IMAP and Sieve, implement STARTTLS also for SMTP: A new TLS socket is built on the already open socket which performs all TLS related actions. The SMTP client then only has to talk on the TLS socket. Note that after issuing STARTTLS command, we have to re-request the supported server capabilities (i.e. send EHLO again and parse the server response), because the announced AUTH mechanism may change. Fixes Alinto#31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stage 9:
These fix build errors on FreeBSD and/or Clang and/or libobjc2.
They address the following issues:
(i) Runtime compatability logic in #if statements needs support for GNUSTEP_RUNTIME.
(ii) Fix build error by setting attribute for root class in EOFault.h.
(iii) Removed need for EXPOSE_?_IVARS in NGBundleManager.m by using isLoaded instead of codeLoaded.
(iv) Removed need for EXPOSE?_IVARS in NSException+misc.h by removing the bad method 'setReason'. All uses of this method have been removed by setting the exceptions' 'reason' at init time, as it should be. An exceptions' 'reason' should be immutable, thus why there is no safe setter for it in NSException.
Setting an ivar is not acceptable, and will be impossible in future versions of GNUstep Runtime.