Added severity to CLI output #48

praxder · 2022-11-23T18:02:36Z

No description provided.

kuhnroyal · 2023-02-27T20:53:19Z

I also added severity in #86 which additionally adds JSON output.

rrousselGit · 2023-06-08T10:19:52Z

@praxder Do you mind fixing the conflicts?

This otherwise looks good to me. I'm happy with giving it a quick merge once that's fixed

vercel · 2023-06-14T16:21:48Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
custom-lint-website	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 20, 2023 1:59pm

CLAassistant · 2023-06-14T16:21:50Z

All committers have signed the CLA.

praxder · 2023-06-14T16:34:39Z

@rrousselGit Updated. I had some trouble testing these changes locally, so I'm not confident that they work. Let me know if I need to change anything else. 😬 Long-term, it would be great to have a Contributors guide in this repo.

rrousselGit · 2023-06-15T09:56:15Z

LGTM! Assuming the tests pass, will merge :)

rrousselGit · 2023-06-15T10:57:41Z

packages/custom_lint/lib/custom_lint.dart

@@ -154,7 +154,7 @@ void _renderLints(
  for (final error in errors) {
    stdout.writeln(
      '  ${_relativeFilePath(error.location.file, workingDirectory)}:${error.location.startLine}:${error.location.startColumn}'
-      ' • ${error.message} • ${error.code}',
+      ' • ${error.message} • ${error.code} • ${lint.severity.name}',


The lint variable doesn't seem to exist. Maybe you're looking for the error variable?

rrousselGit · 2023-06-15T10:58:39Z

If you're looking at running custom_lint locally, one step is to change the packages/custom_lint/tools/analyzer_plugin/pubspec.yaml . See the TODO in there

Change variable name

praxder · 2023-06-16T18:12:02Z

@rrousselGit Updated. I think the one failing test was pre-existing, and introduced as part of this: https://github.com/invertase/dart_custom_lint/actions/runs/5277956808/jobs/9546659176

…into pr/praxder/48

rrousselGit · 2023-06-20T13:59:45Z

LGTM. I'll merge once the "main" CI is fixed. It should be good soon

rrousselGit · 2023-06-20T15:06:59Z

Looks like everything is fine. Thanks for your work!

* Bump version to `0.1.0` * Pull changes from `solid-metrics` repository * Update .gitignore Co-authored-by: Yuri Prykhodko <40931732+solid-yuriiprykhodko@users.noreply.github.com> * Update example/lib/solid_lints_example.dart Co-authored-by: Yuri Prykhodko <40931732+solid-yuriiprykhodko@users.noreply.github.com> * Update `CHANGELOG.md` * Add code checks with GitHub Actions * Add support for the number of parameters metric * Remove DCM references * Change lint message * Simplify configuration and remove redundant code * Fix code comments * Add missing tests * Add `lines_of_code` lint * Fix rule name * Add test and fix an edge case * Update lint to match the specification * Add `avoid_non_null_assertion` lint * Add missing comment * Add `avoid_late_keyword` lint * Update problem message * Add `avoid_global_state` lint * Fix failing tests * Add `avoid_returning_widgets` lint * Use pattern-matching * Simplify `isWidgetReturned` * Update lib/lints/avoid_returning_widgets/avoid_returning_widgets_rule.dart Co-authored-by: Yuri Prykhodko <40931732+solid-yuriiprykhodko@users.noreply.github.com> * Cleanup of `getLintRules` * Fix comment * rename MetricRule -> RuleConfig * add a sceleton for the double-literal-format rule * implement the double-literal-format rule * fix review warnings * implement quick-fix for the double-literal-format rule * fix lint warnings * add avoid-unnecessary-type-assertions rule ('is' part) * fix lint warning * add avoid-unnecessary-type-assertions rule ('whereType' part) * add quick-fix for unnecessary operator is * add quick-fix for unnecessary whereType * fix review warnings; fix a bug * add utility class for type chekcking methods * add constants for is and whereType names * add needed comments * rewrite _isUnnecessaryWhereType with pattern matching * rewrite _areGenericsWithSameTypeArgs with pattern matching * refactoring: move a castTypeInHierarchy to TypeCast class * implement "avoid unnecessary setstate" rule (invertase#44) * implement "avoid unnecessary setstate" rule * fix pr comments * added idea files to gitignore * fix pr comments * Fix merge conflict * Fix tests and improve GitHub workflow * Fix workflow file * Fix conflicts after merge * Remove non-existing import * Add missing rule to tests and remove unnecessary GitHub actions step --------- Co-authored-by: Yaroslav Laptiev <yaroslav.laptiev@wmg.com> Co-authored-by: vladimir-beloded <x-volodymyr.beloded@transcarent.com> * Add avoid_unnecessary_type_casts_rule * Refactor types_utils, extract common methods * Add fix for avoid_unnecessary_type_casts_rule * Add AvoidUnnecessaryTypeCastsRule.createRule to solid_lints.dart * Fix 'quickFix' for avoid-unnecessary-type-casts * Add tests for avoid-unnecessary-type-casts * Fix formatting * Add more test cases * Group code for more readability * Switch to getters, refactor areGenericsWithSameTypeArgs * Avoid unrelated type assertions (invertase#48) * Add avoid-unrelated-type-assertions rule * Add tests for avoid-unrelated-type-assertions rule --------- Co-authored-by: Denis Bogatirov <denis.bohatyrov@computools.com> * Feature/newline before return (invertase#52) * Add newline-before-return rule * Fix typos, remove unnecessary negation * Add tests for newline-before-return --------- Co-authored-by: Denis Bogatirov <denis.bohatyrov@computools.com> * Fixes Issue invertase#54 multiple rule reporting (invertase#55) * Fix newline-before-return * Fix avoid-unrelated-type-assertions * Fix avoid-unnecessary-type-casts --------- Co-authored-by: Denis Bogatirov <denis.bohatyrov@computools.com> * Feature/no empty block (invertase#53) * Add no-empty-block rule * Add tests no-empty-block rule * Add cyclomatic tests case, fix formatting --------- Co-authored-by: Denis Bogatirov <denis.bohatyrov@computools.com> * Add no equal then else rule (invertase#56) * Add no-equal-then-else rule * Add tests for no-equal-then-else rule --------- Co-authored-by: Denis Bogatirov <denis.bohatyrov@computools.com> * Feature/member ordering (invertase#51) * Add required models for member-ordering rule * Add member-ordering rule * Add MIT License comments * Fix parser type mismatch * Add tests for member-ordering and enable rule * Organize imports, ignore member-ordering in unrelated test * Group *_member_group.dart into one directory * Add more test cases * Add more test cases * Add alphabetize test cases * Add tests for alphabetical-by-type option * Ignore no-empty-block in test * Ignore member-ordering in test --------- Co-authored-by: Denis Bogatirov <denis.bohatyrov@computools.com> * Add avoid unused parameters rule (invertase#49) * Add avoid-unused-parameters rule * Add tests for avoid-unused-parameters rule * Fix function name, remove null check operator and remove negation * Fix multiple reporting * Add more test cases * Fix formatting * Rename method * Add constructors and factories unused params handling * Fix constructors with named field parameters * Simplify rule run method * Fix tests * Fix tests after merge * Fix tests after merge --------- Co-authored-by: Denis Bogatirov <denis.bohatyrov@computools.com> * Added no magic number rule (invertase#57) * Add no-magic-number rule * Add tests for no-magic-number rule * Fix import lost in merge * Ignore no-magic-number in test --------- Co-authored-by: Denis Bogatirov <denis.bohatyrov@computools.com> * Added prefer condtional expressions rule and fix (invertase#59) * Add prefer-conditional-expressions rule and fix * Add tests for prefer-conditional-expressions rule * fix nested test plugin path * Fix tests after merge * Update lint_test/prefer_conditional_expressions_ignore_nested_test/prefer_conditional_expressions_ignore_nested_test.dart --------- Co-authored-by: Denis Bogatirov <denis.bohatyrov@computools.com> Co-authored-by: Yurii Prykhodko <144313329+yurii-prykhodko-solid@users.noreply.github.com> * Added prefer first rule (invertase#60) * Add prefer-conditional-expressions rule and fix * Add tests for prefer-conditional-expressions rule * fix nested test plugin path * Fix tests after merge * Add prefer-first rule and fix * Add tests for prefer-first rule --------- Co-authored-by: Denis Bogatirov <denis.bohatyrov@computools.com> Co-authored-by: Yurii Prykhodko <144313329+yurii-prykhodko-solid@users.noreply.github.com> * Add prefer last rule (invertase#61) * Add prefer-conditional-expressions rule and fix * Add tests for prefer-conditional-expressions rule * fix nested test plugin path * Fix tests after merge * Add prefer-first rule and fix * Add tests for prefer-first rule * Add prefer-last rule & fix * Add tests for prefer-last rule --------- Co-authored-by: Denis Bogatirov <denis.bohatyrov@computools.com> Co-authored-by: Yurii Prykhodko <144313329+yurii-prykhodko-solid@users.noreply.github.com> * Add prefer match file name (invertase#62) * Add prefer-conditional-expressions rule and fix * Add tests for prefer-conditional-expressions rule * fix nested test plugin path * Fix tests after merge * Add prefer-first rule and fix * Add tests for prefer-first rule * Add prefer-last rule & fix * Add tests for prefer-last rule * Add prefer-match-file-name rule * Add tests for prefer-match-file-name rule * Typos, naming * Typos, naming * rm todo comment * Update lint_test/prefer_match_file_name_test.dart * Update lint_test/prefer_match_file_name_test.dart --------- Co-authored-by: Denis Bogatirov <denis.bohatyrov@computools.com> Co-authored-by: Yurii Prykhodko <144313329+yurii-prykhodko-solid@users.noreply.github.com> Co-authored-by: Yurii Prykhodko <yurii.prykhodko@solid.software> * Rename custom lints to use snake_case (invertase#66) * Rename custom lints to use snake_case * Rename missed parameter --------- Co-authored-by: vladimir-beloded <x-volodymyr.beloded@transcarent.com> * Take into account the constructor initializer in the avoid_unused_parameters rule (invertase#67) Co-authored-by: vladimir-beloded <x-volodymyr.beloded@transcarent.com> * Fix linter issues * Bump custom_lint_builder version * Update LICENSE to include third party code license * Allow magic numbers for default values (invertase#72) * Allow magic numbers for default values * More tests --------- Co-authored-by: vladimir-beloded <x-volodymyr.beloded@transcarent.com> * Ignore magic number in constructor initializer (invertase#73) * Ignore magic number in constructor initializer * Minor naming improvement --------- Co-authored-by: vladimir-beloded <x-volodymyr.beloded@transcarent.com> * Remove DCM steps from readme * Fix avoid-late if initialized (invertase#71) * Implement proper-super-calls (invertase#77) * Fix avoid-late if initialized * Update lint_test/avoid_late_keyword_test.dart Co-authored-by: Yurii Prykhodko <144313329+yurii-prykhodko-solid@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Yurii Prykhodko <144313329+yurii-prykhodko-solid@users.noreply.github.com> * Custom avoid-late * Fix naming * Apply suggestions from code review Co-authored-by: Yurii Prykhodko <144313329+yurii-prykhodko-solid@users.noreply.github.com> * Avoid late simplified * Update lib/lints/avoid_late_keyword/models/avoid_late_keyword_parameters.dart Co-authored-by: Yurii Prykhodko <144313329+yurii-prykhodko-solid@users.noreply.github.com> * Avoid-late ignored_types * Avoid-late ignored_types formatted * Update lib/lints/avoid_late_keyword/models/avoid_late_keyword_parameters.dart Co-authored-by: Yurii Prykhodko <144313329+yurii-prykhodko-solid@users.noreply.github.com> * Avoid-late ignored_types fix * Avoid-late ignored_types Fix * Avoid-late allow_initialized testcases * Update lint_test/avoid_late_keyword_allow_initialized_test/pubspec.yaml Co-authored-by: Yurii Prykhodko <144313329+yurii-prykhodko-solid@users.noreply.github.com> * Update lib/lints/avoid_late_keyword/models/avoid_late_keyword_parameters.dart Co-authored-by: Yurii Prykhodko <144313329+yurii-prykhodko-solid@users.noreply.github.com> * Allow subclasses for avoid-late whitelist * Fix naming * Short-circuit of there's no ignored types * Short-circuit earlier * Update lib/lints/avoid_late_keyword/avoid_late_keyword_rule.dart Co-authored-by: Yurii Prykhodko <144313329+yurii-prykhodko-solid@users.noreply.github.com> * Avoid-late ignored_types tests * Avoid-late add testcases * Proper-super-calls impl * Proper-super-calls format * Apply suggestions from code review Co-authored-by: Yurii Prykhodko <144313329+yurii-prykhodko-solid@users.noreply.github.com> * Proper-super-calls refactoring * Update lib/lints/proper_super_calls/proper_super_calls_rule.dart Co-authored-by: Yurii Prykhodko <144313329+yurii-prykhodko-solid@users.noreply.github.com> * Proper-super-keyword annotation check * Proper-super-keyword format * Proper-super-calls cleanup --------- Co-authored-by: Yurii Prykhodko <144313329+yurii-prykhodko-solid@users.noreply.github.com> Co-authored-by: Yurii Prykhodko <yurii.prykhodko@solid.software> * Ignore magic numbers in widget parameters (invertase#74) * Ignore magic numbers in widget parameters * Add lint parameter to ignore magic numbers in widget params * Improve the allowed_in_widget_params parameter to exclude magic numbers in nested objects of Widget parameters * Add tests for disabled allowed_in_widget_params lint parameter * Remove unnecessary dependency --------- Co-authored-by: vladimir-beloded <x-volodymyr.beloded@transcarent.com> * Set default severity level to warning (invertase#78) Co-authored-by: vladimir-beloded <x-volodymyr.beloded@transcarent.com> --------- Co-authored-by: Nikodem Bernat <n.bernat@outlook.com> Co-authored-by: Vadym Khokhlov <xvadima@ukr.net> Co-authored-by: Yaroslav <43727448+laptevw@users.noreply.github.com> Co-authored-by: Yaroslav Laptiev <yaroslav.laptiev@wmg.com> Co-authored-by: vladimir-beloded <x-volodymyr.beloded@transcarent.com> Co-authored-by: Denis Bogatirov <denis.bohatyrov@computools.com> Co-authored-by: DenisBogatirov <denis.bogatirov@gmail.com> Co-authored-by: Yurii Prykhodko <144313329+yurii-prykhodko-solid@users.noreply.github.com> Co-authored-by: solid-vovabeloded <41615621+solid-vovabeloded@users.noreply.github.com> Co-authored-by: Illia Romanenko <442086+illia-romanenko@users.noreply.github.com> Co-authored-by: maxxlab <42914015+maxxlab@users.noreply.github.com>

praxder force-pushed the main branch from 37fa415 to 4f039bb Compare November 28, 2022 14:32

rrousselGit self-assigned this May 24, 2023

vercel bot deployed to Preview June 14, 2023 16:22 View deployment

added severity to output

8ff3499

praxder force-pushed the main branch from 552e9d4 to 8ff3499 Compare June 14, 2023 16:31

vercel bot deployed to Preview June 14, 2023 16:31 View deployment

rrousselGit approved these changes Jun 15, 2023

View reviewed changes

rrousselGit reviewed Jun 15, 2023

View reviewed changes

Update custom_lint.dart

315fc47

Change variable name

vercel bot deployed to Preview June 15, 2023 13:16 View deployment

reference fix

51bca20

vercel bot deployed to Preview June 15, 2023 13:24 View deployment

Updated more tests

3692ae9

vercel bot deployed to Preview June 15, 2023 13:45 View deployment

test update

a5ed82a

vercel bot deployed to Preview June 15, 2023 14:00 View deployment

Merge branch 'main' of https://github.com/invertase/dart_custom_lint …

3e13f9f

…into pr/praxder/48

vercel bot deployed to Preview June 20, 2023 13:59 View deployment

rrousselGit merged commit 4a31bc0 into invertase:main Jun 20, 2023
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added severity to CLI output #48

Added severity to CLI output #48

praxder commented Nov 23, 2022

kuhnroyal commented Feb 27, 2023

rrousselGit commented Jun 8, 2023

vercel bot commented Jun 14, 2023 •

edited

Loading

CLAassistant commented Jun 14, 2023 •

edited

Loading

praxder commented Jun 14, 2023

rrousselGit commented Jun 15, 2023

rrousselGit Jun 15, 2023

rrousselGit commented Jun 15, 2023

praxder commented Jun 16, 2023

rrousselGit commented Jun 20, 2023

rrousselGit commented Jun 20, 2023

Added severity to CLI output #48

Added severity to CLI output #48

Conversation

praxder commented Nov 23, 2022

kuhnroyal commented Feb 27, 2023

rrousselGit commented Jun 8, 2023

vercel bot commented Jun 14, 2023 • edited Loading

CLAassistant commented Jun 14, 2023 • edited Loading

praxder commented Jun 14, 2023

rrousselGit commented Jun 15, 2023

rrousselGit Jun 15, 2023

Choose a reason for hiding this comment

rrousselGit commented Jun 15, 2023

praxder commented Jun 16, 2023

rrousselGit commented Jun 20, 2023

rrousselGit commented Jun 20, 2023

vercel bot commented Jun 14, 2023 •

edited

Loading

CLAassistant commented Jun 14, 2023 •

edited

Loading