Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: use <<= 1 replace *=2 #29

Merged
merged 1 commit into from Aug 18, 2021
Merged

perf: use <<= 1 replace *=2 #29

merged 1 commit into from Aug 18, 2021

Conversation

xyuanbuilds
Copy link
Contributor

maybe better

@CLAassistant
Copy link

CLAassistant commented Feb 9, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.419% when pulling c8b8f22 on xyuanbuilds:patch-1 into 0420632 on invertase:master.

@Salakar Salakar changed the title fix: use <<= 1 replace *=2 perf: use <<= 1 replace *=2 Aug 18, 2021
Salakar
Salakar approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@Salakar Salakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, I did manage to test this today and it is only marginally faster - but happy to ship it

@Salakar Salakar merged commit ba45cbd into invertase:master Aug 18, 2021
@xyuanbuilds xyuanbuilds deleted the patch-1 branch October 29, 2021 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Salakar Salakar Salakar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xyuanbuilds @CLAassistant @coveralls @Salakar