Skip to content

Commit

Permalink
fix: ensure upload-symbol script works for every build type
Browse files Browse the repository at this point in the history
  • Loading branch information
russellwheatley committed Feb 29, 2024
1 parent ff39fb3 commit 008b35a
Showing 1 changed file with 4 additions and 11 deletions.
15 changes: 4 additions & 11 deletions packages/flutterfire_cli/lib/src/commands/upload_symbols.dart
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,8 @@ class UploadCrashlyticsSymbols extends FlutterFireCommand {
],
environment: {
'PLATFORM_NAME': envPlatformName,
'CONFIGURATION': envConfiguration,
// Hard code "Release" to ensure "App.framework.dsym" is uploaded and complies with upload-symbol script
'CONFIGURATION': 'Release',
'PROJECT_DIR': envProjectDir,
'DWARF_DSYM_FOLDER_PATH': envDwarfDsymFolderPath,
'DWARF_DSYM_FILE_NAME': envDwarfDsymFileName,
Expand All @@ -371,15 +372,6 @@ class UploadCrashlyticsSymbols extends FlutterFireCommand {
if (validationScript.exitCode != 0) {
throw Exception(validationScript.stderr);
}
print('uploadSymbolsScriptPath: $uploadSymbolsScriptPath');
print('appIdFilePath: $appIdFilePath');
print('envPlatformName: $envPlatformName');
print('envConfiguration: $envConfiguration');
print('envProjectDir: $envProjectDir');
print('envDwarfDsymFolderPath: $envDwarfDsymFolderPath');
print('envDwarfDsymFileName: $envDwarfDsymFileName');
print('envInfoPlistPath: $envInfoPlistPath');
print('envBuildProductsDir: $envBuildProductsDir');
// Upload script
final uploadScript = await Process.run(
uploadSymbolsScriptPath,
Expand All @@ -389,7 +381,8 @@ class UploadCrashlyticsSymbols extends FlutterFireCommand {
],
environment: {
'PLATFORM_NAME': envPlatformName,
'CONFIGURATION': envConfiguration,
// Hard code "Release" to ensure "App.framework.dsym" is uploaded and complies with upload-symbol script
'CONFIGURATION': 'Release',
'PROJECT_DIR': envProjectDir,
'DWARF_DSYM_FOLDER_PATH': envDwarfDsymFolderPath,
'DWARF_DSYM_FILE_NAME': envDwarfDsymFileName,
Expand Down

0 comments on commit 008b35a

Please sign in to comment.