fix: ensure Crashlytics Apple upload-symbol script works for every build type/flavor #260
Conversation
russellwheatley
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
russellwheatley
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
russellwheatley
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
russellwheatley
changed the title
russellwheatley
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
russellwheatley
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
russellwheatley
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
russellwheatley
changed the title
russellwheatley
changed the title
| @@ -359,7 +359,8 @@ class UploadCrashlyticsSymbols extends FlutterFireCommand { | |||
| ], | |||
| environment: { | |||
| 'PLATFORM_NAME': envPlatformName, | |||
| 'CONFIGURATION': envConfiguration, | |||
| // Hard code "Release" to ensure "App.framework.dsym" is uploaded and complies with upload-symbol script | |||
| 'CONFIGURATION': 'Release', | |||
There was a problem hiding this comment.
Can we try if this works for Debug mode as well? I don't think debug mode flutter produces framework dsym. If not, let's doing a check, if envConfiguration contain debug word we pass Debug, otherwise Release.
There was a problem hiding this comment.
Also want to double check how customizable for user to change Configuration name for flutter? I see for flutter application you can change the config name quiet easy, but under properties for native app configuration there are only debug and release options. If we allow user to change configuration name by themselves it could easily break the current check for Release and Debug mode.
There was a problem hiding this comment.
As mentioned in the chat, this solution is more robust than checking the name of the build configuration.
russellwheatley
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
russellwheatley
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
russellwheatley
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
Description
fixes: #249
Type of Change
feat-- New feature (non-breaking change which adds functionality)fix-- Bug fix (non-breaking change which fixes an issue)!-- Breaking change (fix or feature that would cause existing functionality to change)refactor-- Code refactorci-- Build configuration changedocs-- Documentationchore-- Chore