Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FlutterFire CLI is not able to handle projects that use… #306

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

devNamanG
Copy link

… Kotlin DSL for Gradle #305

Description

Added support for updating android/build.gradle.kts, android/settings.gradle.kts and android/app/build.gradle.kts files.
Added RegExps, functions to handle Kotlin Gradle DSL files if Groovy Gradle DSL files are not found
We assume that the project does not use a mix of Groovy and Kotlin DSL gradle files.
We check whether the android/build.gradle file exists or not. If it exists, the existing code handles updating the files.
If it does not not exist, we proceed to check whether android/build.gradle.kts file exists.
If it does, we use Kotlin DSL configuration.
If both configuration files are not found, an Exception is thrown.

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

@CLAassistant
Copy link

CLAassistant commented Jun 1, 2024

CLA assistant check
All committers have signed the CLA.

@devNamanG devNamanG changed the title Fixes [bug]: FlutterFire CLI is not able to handle projects that use… fix: FlutterFire CLI is not able to handle projects that use… Jun 1, 2024
@devNamanG
Copy link
Author

Okay so I tried running the code on a project with Kotlin DSL files, and for some reason, it is not updating the those files, even though it does write google-services.json. Can someone check this out as well? The existing plugin code seems to not even call the updated gradleContentUpdates function. It would be really helpful if a maintainer checks this out, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants