feat(globe_cli): Added login url in output of login command (#34)

* feat(globe_cli): added login url in output of login command * feat(globe_cli): formatting * feat(globe_cli): updated test cases * feat(globe_cli): formatting * feat(globe_cli): analyzer
invertase · Jan 19, 2024 · 5294dcb · 5294dcb
1 parent 71c5988
commit 5294dcb
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 5 deletions.
diff --git a/packages/globe_cli/lib/src/commands/login_command.dart b/packages/globe_cli/lib/src/commands/login_command.dart
@@ -40,8 +40,11 @@ class LoginCommand extends BaseGlobeCommand {
       onConnected: (port) async {
         logger.info('Please authenticate via the opened browser window.');
         // TODO can we react to openUrl close, to have the command emit a "failed to login"?
+        final url =
+            '$endpoint/login/cli?callback=http://localhost:$port/callback?strategy=${GlobeHttpServerRedirectStrategy.redirect.name}';
+        logger.info('\nOr go to this link: $url\n');
         await openUrl(
-          '$endpoint/login/cli?callback=http://localhost:$port/callback?strategy=${GlobeHttpServerRedirectStrategy.redirect.name}',
+          url,
         );
       },
     );

diff --git a/packages/globe_cli/lib/src/utils/open_url.dart b/packages/globe_cli/lib/src/utils/open_url.dart
@@ -25,8 +25,7 @@ String get _openUrlCommand {
     return 'open';
   } else {
     throw UnsupportedError(
-      'Operating system not supported by the open_url '
-      'package: ${Platform.operatingSystem}',
+      'Operating system not supported: ${Platform.operatingSystem}',
     );
   }
 }
diff --git a/packages/globe_cli/test/login_test.dart b/packages/globe_cli/test/login_test.dart
@@ -58,18 +58,24 @@ void main() {
         ),
       );
 
+      const url =
+          'https://globe.dev/login/cli?callback=http://localhost:4242/callback?strategy=redirect';
+
       await expectLater(
         result.testOutputByLines,
         emitsInOrder([
           'Please authenticate via the opened browser window.',
+          '',
+          'Or go to this link: $url',
+          '',
           'Successfully logged in.',
           emitsDone,
         ]),
       );
 
       verify(
         openUrlMock(
-          'https://globe.dev/login/cli?callback=http://localhost:4242/callback?strategy=redirect',
+          url,
         ),
       ).called(1);
       verifyNoMoreInteractions(openUrlMock);
@@ -109,18 +115,24 @@ void main() {
         ),
       );
 
+      const url =
+          'https://globe.dev/login/cli?callback=http://localhost:4242/callback?strategy=redirect';
+
       await expectLater(
         result.testOutputByLines,
         emitsInOrder([
           'Please authenticate via the opened browser window.',
+          '',
+          'Or go to this link: $url',
+          '',
           'err: Failed to login.',
           emitsDone,
         ]),
       );
 
       verify(
         openUrlMock(
-          'https://globe.dev/login/cli?callback=http://localhost:4242/callback?strategy=redirect',
+          url,
         ),
       ).called(1);
       verifyNoMoreInteractions(openUrlMock);