refactor: fix analyzer issues (#590)

invertase · Oct 16, 2023 · 2f19770 · 2f19770
1 parent b049ed8
commit 2f19770
Show file tree

Hide file tree

Showing 13 changed files with 31 additions and 31 deletions.
diff --git a/packages/melos/lib/src/commands/bootstrap.dart b/packages/melos/lib/src/commands/bootstrap.dart
@@ -18,7 +18,7 @@ mixin _BootstrapMixin on _CleanMixin {
             workspace: workspace,
           ),
           'get',
-          if (workspace.config.commands.bootstrap.runPubGetOffline) '--offline'
+          if (workspace.config.commands.bootstrap.runPubGetOffline) '--offline',
         ].join(' ');
 
         logger
@@ -163,7 +163,7 @@ mixin _BootstrapMixin on _CleanMixin {
         workspace: workspace,
       ),
       'get',
-      if (workspace.config.commands.bootstrap.runPubGetOffline) '--offline'
+      if (workspace.config.commands.bootstrap.runPubGetOffline) '--offline',
     ];
 
     final process = await startCommandRaw(

diff --git a/packages/melos/lib/src/commands/list.dart b/packages/melos/lib/src/commands/list.dart
@@ -76,7 +76,7 @@ mixin _ListMixin on _Melos {
                 package.name,
                 AnsiStyles.green((package.version).toString()),
                 AnsiStyles.gray(printablePath(package.pathRelativeToWorkspace)),
-                if (package.isPrivate) AnsiStyles.red('PRIVATE')
+                if (package.isPrivate) AnsiStyles.red('PRIVATE'),
               ],
             )
             .cast<List<String>>()
@@ -132,7 +132,7 @@ mixin _ListMixin on _Melos {
         'version': package.version.toString(),
         'private': package.isPrivate,
         'location': packagePath,
-        'type': package.type.index
+        'type': package.type.index,
       };
 
       if (long) {

diff --git a/packages/melos/lib/src/commands/publish.dart b/packages/melos/lib/src/commands/publish.dart
@@ -77,7 +77,7 @@ mixin _PublishMixin on _ExecMixin {
               AnsiStyles.dim(latestPublishedVersionForPackages[package.name]),
               AnsiStyles.green(package.version.toString()),
             ];
-          })
+          }),
         ],
         paddingSize: 4,
       ),

diff --git a/packages/melos/lib/src/commands/version.dart b/packages/melos/lib/src/commands/version.dart
@@ -143,7 +143,7 @@ mixin _VersionMixin on _RunMixin {
       for (final package in workspace.filteredPackages.values)
         if (!packagesToManuallyVersion.contains(package))
           if (packagesWithVersionableCommits.contains(package.name))
-            if (!asStableRelease || !package.version.isPreRelease) package
+            if (!asStableRelease || !package.version.isPreRelease) package,
     };
     final packagesToVersion = {
       ...packagesToManuallyVersion,
@@ -662,7 +662,7 @@ mixin _VersionMixin on _RunMixin {
       if (updateDependentsConstraints) {
         await Future.forEach([
           ...pendingPackageUpdate.package.dependentsInWorkspace.values,
-          ...pendingPackageUpdate.package.devDependentsInWorkspace.values
+          ...pendingPackageUpdate.package.devDependentsInWorkspace.values,
         ], (package) {
           return _setDependencyVersionForDependentPackage(
             package,
@@ -710,7 +710,7 @@ mixin _VersionMixin on _RunMixin {
     final dateSlug = [
       today.year.toString(),
       today.month.toString().padLeft(2, '0'),
-      today.day.toString().padLeft(2, '0')
+      today.day.toString().padLeft(2, '0'),
     ].join('-');
 
     final packages =

diff --git a/packages/melos/lib/src/common/utils.dart b/packages/melos/lib/src/common/utils.dart
@@ -591,10 +591,10 @@ bool isPubSubcommand({required MelosWorkspace workspace}) {
 void sortPackagesForPublishing(List<Package> packages) {
   final packageNames = packages.map((package) => package.name).toList();
   final graph = <String, Iterable<String>>{
-    for (var package in packages)
+    for (final package in packages)
       package.name: [
         ...package.dependencies.where(packageNames.contains),
-        ...package.devDependencies.where(packageNames.contains)
+        ...package.devDependencies.where(packageNames.contains),
       ],
   };
   final ordered =

diff --git a/packages/melos/lib/src/package.dart b/packages/melos/lib/src/package.dart
@@ -480,7 +480,7 @@ class PackageMap {
       ignore: [
         ...ignore,
         for (final pattern in _commonIgnorePatterns)
-          createGlob(pattern, currentDirectoryPath: workspacePath)
+          createGlob(pattern, currentDirectoryPath: workspacePath),
       ],
     );
 

diff --git a/packages/melos/test/commands/bootstrap_test.dart b/packages/melos/test/commands/bootstrap_test.dart
@@ -333,7 +333,7 @@ Generating IntelliJ IDE files...
           mergeMelosPubspecOverrides(
             {
               for (final entry in melosDependencyOverrides.entries)
-                entry.key: PathReference(entry.value)
+                entry.key: PathReference(entry.value),
             },
             currentPubspecOverrides,
           ),

diff --git a/packages/melos/test/commands/clean_test.dart b/packages/melos/test/commands/clean_test.dart
@@ -41,8 +41,8 @@ void main() {
         pubspecOverrides,
         yamlFile({
           'dependency_overrides': {
-            'a': {'path': relativePath(packageADir.path, packageBDir.path)}
-          }
+            'a': {'path': relativePath(packageADir.path, packageBDir.path)},
+          },
         }),
       );
 

diff --git a/packages/melos/test/commands/run_test.dart b/packages/melos/test/commands/run_test.dart
@@ -31,7 +31,7 @@ void main() {
                 packageFilters: PackageFilters(
                   fileExists: const ['log.txt'],
                 ),
-              )
+              ),
             }),
           ),
         );
@@ -155,7 +155,7 @@ melos run hello
               name: 'hello',
               run: 'echo',
               exec: ExecOptions(),
-            )
+            ),
           }),
         ),
       );
@@ -225,7 +225,7 @@ melos run hello
               exec: ExecOptions(
                 concurrency: 1,
               ),
-            )
+            ),
           }),
         ),
       );

diff --git a/packages/melos/test/package_test.dart b/packages/melos/test/package_test.dart
@@ -72,7 +72,7 @@ void main() {
             MockPackageFs(
               name: 'melos',
               version: Version(0, 0, 0),
-            )
+            ),
           ],
         ),
       );

diff --git a/packages/melos/test/utils.dart b/packages/melos/test/utils.dart
@@ -171,7 +171,7 @@ Future<Directory> createProject(
       else ...[
         'packages',
         pubSpec.name!,
-      ]
+      ],
     ]),
   );
 

diff --git a/packages/melos/test/workspace_config_test.dart b/packages/melos/test/workspace_config_test.dart
@@ -67,7 +67,7 @@ void main() {
             runPubGetInParallel: false,
             runPubGetOffline: true,
             dependencyOverridePaths: [
-              createGlob('a', currentDirectoryPath: '.')
+              createGlob('a', currentDirectoryPath: '.'),
             ],
           ),
         );
@@ -155,7 +155,7 @@ void main() {
                   'packageFilters': {'flutter': true},
                   'description': 'Changelog for all foo packages.',
                 }
-              ]
+              ],
             },
             workspacePath: '.',
           ),
@@ -215,7 +215,7 @@ void main() {
             const {
               'bootstrap': {
                 'runPubGetInParallel': true,
-              }
+              },
             },
             workspacePath: '.',
           ),
@@ -236,7 +236,7 @@ void main() {
             const {
               'bootstrap': {
                 'runPubGetOffline': true,
-              }
+              },
             },
             workspacePath: '.',
           ),
@@ -256,7 +256,7 @@ void main() {
                 'message': 'Hello world',
                 'branch': 'main',
                 'linkToCommits': true,
-              }
+              },
             },
             workspacePath: '.',
           ),
@@ -429,7 +429,7 @@ void main() {
               'exec': {
                 'concurrency': 1,
                 'failFast': true,
-                'orderDependents': true
+                'orderDependents': true,
               },
             },
           }),
@@ -520,7 +520,7 @@ void main() {
         expect(
           () => MelosWorkspaceConfig.fromYaml(
             createYamlMap({
-              'packages': <Object?>['*']
+              'packages': <Object?>['*'],
             }),
             path: testWorkspacePath,
           ),
@@ -617,7 +617,7 @@ void main() {
           () => MelosWorkspaceConfig.fromYaml(
             createYamlMap(
               {
-                'packages': [42]
+                'packages': [42],
               },
               defaults: configMapDefaults,
             ),
@@ -658,7 +658,7 @@ void main() {
           () => MelosWorkspaceConfig.fromYaml(
             createYamlMap(
               {
-                'ignore': [42]
+                'ignore': [42],
               },
               defaults: configMapDefaults,
             ),

diff --git a/packages/melos/test/workspace_test.dart b/packages/melos/test/workspace_test.dart
@@ -160,7 +160,7 @@ The packages that caused the problem are:
           configBuilder: (path) => MelosWorkspaceConfig.fromYaml(
             const {
               'name': 'test',
-              'packages': ['.']
+              'packages': ['.'],
             },
             path: path,
           ),
@@ -185,7 +185,7 @@ The packages that caused the problem are:
           configBuilder: (path) => MelosWorkspaceConfig.fromYaml(
             const {
               'name': 'test',
-              'packages': ['packages/a']
+              'packages': ['packages/a'],
             },
             path: path,
           ),
@@ -246,7 +246,7 @@ The packages that caused the problem are:
               config,
               packageFilters: PackageFilters(
                 scope: [
-                  createGlob('b', currentDirectoryPath: workspaceDir.path)
+                  createGlob('b', currentDirectoryPath: workspaceDir.path),
                 ],
                 includeDependencies: true,
               ),