Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update installation.md #946

Closed
wants to merge 2 commits into from
Closed

docs: Update installation.md #946

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22e79a5
Update installation.md
yaberkane05 Jan 3, 2024
7c0afdd
docs: Update installation.md
yaberkane05 Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 0 additions & 18 deletions docs-react-native/react-native/docs/installation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,24 +66,6 @@ If, however, you're currently compiling your app for SDK version lower than 33,

`npx expo install expo-build-properties`

Then, add `@notifee/react-native` to the list of plugins in your app's Expo config (`app.json` or `app.config.js`):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you just need to replace @notifee/react-native by expo-build-properties

Then, add expo-build-properties to the list of plugins in your app's Expo config (app.json or app.config.js):

```js
{
"name": "my app",
"plugins": [
[
"expo-build-properties",
{
"android": {
"compileSdkVersion": 33,
"targetSdkVersion": 33 // Only needed if requesting permission on Android 13 via requestPermission, at least 33
},
},
],
]
}
```

Finally, ensure you run `npx expo prebuild` and rebuild your app as described in the ["Adding custom native code"](https://docs.expo.io/workflow/customizing/) guide.

Please note that Notifee needs Java JDK 11+ to build on Android. If you are building the app with EAS, you need to change the image used for the build. You will have to use `image` as `ubuntu-18.04-jdk-11-ndk-r19c` or another image that has jdk 11 as in the following configuration. ([EAS Build Server Configuration](https://docs.expo.dev/build-reference/infrastructure/#image--ubuntu-1804-jdk-8-ndk-r19c--alias--default))
Expand Down