Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message for mis-configured apple sign in not different from device version wrong message #108

Open
mikehardy opened this issue Jul 7, 2020 · 4 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@mikehardy
Copy link
Collaborator

Very interesting - forgive me while I "active listen" here - I am going to try to say what you said, to see if I understand it

If you have not done the full iOS Developer Console setup for the app to enable apple sign in, then when you go to use it you get an error message about not having the right iOS version

Is that right? I am not 100% sure on the first part, but I am pretty sure I understand you've found the thing that causes a iOS version not supported message when really it has nothing to do with a version. Hopefully we can fix it

Yes, it is my point!
Just to compare, in Google API Login, if we do mis configuration in Google Console (sha, key, or other thinks) we have code 10 error. But, if we trying use in unsupported device we have code 320. So, we can figure out where we do it wrong.
I suggestion to open a issue about that just to not lose this improve.

Originally posted by @Lucasark in #103 (comment)

@mikehardy
Copy link
Collaborator Author

@Lucasark - thanks for helping diagnose this, we haven't known about this issue until now and couldn't get enough specifics to make anything actionable. I think we have something to work with here!

@mikehardy mikehardy added bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers labels Jul 7, 2020
@mikehardy
Copy link
Collaborator Author

At minimum this needs a documentation fix so I tagged that, but also if the underlying Apple SDK gives us different error messages to separate these two cases at all, the code should differentiate them of course

@karanwadhwa
Copy link

I got the same error as well, the issue with me was RNAppleAuthentication did not get auto linked. I dont think this is an issue with the library, it's probably my project - I've had similar auto linking failures on this project before; nvm I ran the link command, installed the RNAppleAuthentication pod and it worked fine after.

@mikehardy
Copy link
Collaborator Author

Yeah - apparently @dawntommm just discovered in #185 that if you forget to pod install it maps to "AppleAuth is not supported on this device" also (or at least similarly) which is a pretty terrible user experience compared to other modules I actually maintain which will tell you the native module is missing 😅

Haven't had time to dig and fix this one yet but if anyone else does a PR would be lovely 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants