Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: FieldValue.arrayRemove, FieldValue.arrayUnion #134

Merged

Conversation

andrevus
Copy link
Contributor

@andrevus andrevus commented Oct 23, 2018

@CLAassistant
Copy link

CLAassistant commented Oct 23, 2018

CLA assistant check
All committers have signed the CLA.

Author:    Andrzej Lewandowski <andrevus@gmail.com>
@andrevus andrevus force-pushed the feat/fieldvalue_union_remove_docs branch from 8f00656 to ff1c3cf Compare October 23, 2018 09:39
@Salakar
Copy link
Member

Salakar commented Oct 23, 2018

Thanks for this 👌

@Salakar Salakar merged commit 572a5f8 into invertase:master Oct 23, 2018
Salakar pushed a commit to invertase/react-native-firebase that referenced this pull request Oct 23, 2018
#1624)

### Summary

Add methods arrayRemove and arrayUnion to work with arrays in firestore.

Fixes #1389

### Checklist
* [x]  Supports `Android`
* [x]  Supports `iOS`
* [x]  `e2e` tests added or updated in [/tests/e2e/*](/tests/e2e)
* [x]  Updated the documentation in the [docs repo](https://github.com/invertase/react-native-firebase-docs)

invertase/react-native-firebase-docs#134

* [x]  Flow types updated
* [x]  Typescript types updated
Salakar added a commit that referenced this pull request Nov 5, 2018
* Update ios.md

* misc

as per license previously indicated on the docs website footer - no changes

* update docs to use Firebases new dynamic link url

* docs: FieldValue.arrayRemove, FieldValue.arrayUnion (#134)

Author:    Andrzej Lewandowski <andrevus@gmail.com>

* Update IOSNotification.md

* Update receiving-notifications.md (#135)

### Abstract
Updated markdown broken style in the receiving-notifications.md.

### Before and after
<img width="188" alt="screen shot 2018-10-23 at 5 30 01 pm" src="https://user-images.githubusercontent.com/4126751/47372141-709f1d00-d6e9-11e8-9ba3-e8dac6b957e5.png">

* Add IOSMessaging module (#137)

IOSMessaging documentation

* Update initial-setup.md (#138)

Proposal to add the following guide to the initial setup guide, as per the following @Salakar suggestion:
invertase/react-native-firebase#1641 (comment)

* initial draft v5.1.0 release notes

* v5.1.0 release notes

* v5.1.0 release notes

* v5.1.0 release notes

* v5.1.0 version changes

* fixed typos and added markdown formatting to some texts (#130)

* [ios] update fabric versions

* Update App.md

* Update release-notes.md
Salakar added a commit that referenced this pull request Jan 3, 2019
* v5.1.0 (#146)

* Update ios.md

* misc

as per license previously indicated on the docs website footer - no changes

* update docs to use Firebases new dynamic link url

* docs: FieldValue.arrayRemove, FieldValue.arrayUnion (#134)

Author:    Andrzej Lewandowski <andrevus@gmail.com>

* Update IOSNotification.md

* Update receiving-notifications.md (#135)

### Abstract
Updated markdown broken style in the receiving-notifications.md.

### Before and after
<img width="188" alt="screen shot 2018-10-23 at 5 30 01 pm" src="https://user-images.githubusercontent.com/4126751/47372141-709f1d00-d6e9-11e8-9ba3-e8dac6b957e5.png">

* Add IOSMessaging module (#137)

IOSMessaging documentation

* Update initial-setup.md (#138)

Proposal to add the following guide to the initial setup guide, as per the following @Salakar suggestion:
invertase/react-native-firebase#1641 (comment)

* initial draft v5.1.0 release notes

* v5.1.0 release notes

* v5.1.0 release notes

* v5.1.0 release notes

* v5.1.0 version changes

* fixed typos and added markdown formatting to some texts (#130)

* [ios] update fabric versions

* Update App.md

* Update release-notes.md

* Update getting-started.md

* Update admob.md

* Update Messaging.md

* Update Messaging.md

* Update Trace.md

* Update HttpMetric.md

* v5.1.1 release notes

* Update ios.md (#148)

GoogleService-Info.plist has to be added via XCode's "Add Files" to the project

* Create about.md

* Update _sidebar.yaml

* misc

* Update about.md

* Update about.md

* Update about.md

* Update about.md
Salakar added a commit that referenced this pull request Jan 22, 2019
* Sync v5.x.x -> master (#154)

* v5.1.0 (#146)

* Update ios.md

* misc

as per license previously indicated on the docs website footer - no changes

* update docs to use Firebases new dynamic link url

* docs: FieldValue.arrayRemove, FieldValue.arrayUnion (#134)

Author:    Andrzej Lewandowski <andrevus@gmail.com>

* Update IOSNotification.md

* Update receiving-notifications.md (#135)

### Abstract
Updated markdown broken style in the receiving-notifications.md.

### Before and after
<img width="188" alt="screen shot 2018-10-23 at 5 30 01 pm" src="https://user-images.githubusercontent.com/4126751/47372141-709f1d00-d6e9-11e8-9ba3-e8dac6b957e5.png">

* Add IOSMessaging module (#137)

IOSMessaging documentation

* Update initial-setup.md (#138)

Proposal to add the following guide to the initial setup guide, as per the following @Salakar suggestion:
invertase/react-native-firebase#1641 (comment)

* initial draft v5.1.0 release notes

* v5.1.0 release notes

* v5.1.0 release notes

* v5.1.0 release notes

* v5.1.0 version changes

* fixed typos and added markdown formatting to some texts (#130)

* [ios] update fabric versions

* Update App.md

* Update release-notes.md

* Update getting-started.md

* Update admob.md

* Update Messaging.md

* Update Messaging.md

* Update Trace.md

* Update HttpMetric.md

* v5.1.1 release notes

* Update ios.md (#148)

GoogleService-Info.plist has to be added via XCode's "Add Files" to the project

* Create about.md

* Update _sidebar.yaml

* misc

* Update about.md

* Update about.md

* Update about.md

* Update about.md

* Correct error codes for verifyPhoneNumber function (#158)

Removed old two which are incorrect. Added 5 error codes in Firebase JS Doc

* Update Social Media Auth page with Twitter Signin (#157)

I've tested this with both iOS and Android and it worked. Let me know if there's anything that should be changed

🔥

* [auth] cleanup social auth examples + fix twitter example
@Salakar Salakar mentioned this pull request Jan 22, 2019
Salakar added a commit that referenced this pull request Jan 22, 2019
* Sync v5.x.x -> master (#154)

* v5.1.0 (#146)

* Update ios.md

* misc

as per license previously indicated on the docs website footer - no changes

* update docs to use Firebases new dynamic link url

* docs: FieldValue.arrayRemove, FieldValue.arrayUnion (#134)

Author:    Andrzej Lewandowski <andrevus@gmail.com>

* Update IOSNotification.md

* Update receiving-notifications.md (#135)

### Abstract
Updated markdown broken style in the receiving-notifications.md.

### Before and after
<img width="188" alt="screen shot 2018-10-23 at 5 30 01 pm" src="https://user-images.githubusercontent.com/4126751/47372141-709f1d00-d6e9-11e8-9ba3-e8dac6b957e5.png">

* Add IOSMessaging module (#137)

IOSMessaging documentation

* Update initial-setup.md (#138)

Proposal to add the following guide to the initial setup guide, as per the following @Salakar suggestion:
invertase/react-native-firebase#1641 (comment)

* initial draft v5.1.0 release notes

* v5.1.0 release notes

* v5.1.0 release notes

* v5.1.0 release notes

* v5.1.0 version changes

* fixed typos and added markdown formatting to some texts (#130)

* [ios] update fabric versions

* Update App.md

* Update release-notes.md

* Update getting-started.md

* Update admob.md

* Update Messaging.md

* Update Messaging.md

* Update Trace.md

* Update HttpMetric.md

* v5.1.1 release notes

* Update ios.md (#148)

GoogleService-Info.plist has to be added via XCode's "Add Files" to the project

* Create about.md

* Update _sidebar.yaml

* misc

* Update about.md

* Update about.md

* Update about.md

* Update about.md

* Correct error codes for verifyPhoneNumber function (#158)

Removed old two which are incorrect. Added 5 error codes in Firebase JS Doc

* Update Social Media Auth page with Twitter Signin (#157)

I've tested this with both iOS and Android and it worked. Let me know if there's anything that should be changed

🔥

* [auth] cleanup social auth examples + fix twitter example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants