feat(perf): Expose modular API that matches the Firebase web JS SDK v…

…9 API (#6771) Co-authored-by: Mike Hardy <github@mikehardy.net>
invertase · Feb 3, 2023 · 4e170ea · 4e170ea · vercel · Feb 3, 2023
1 parent 53a4362
commit 4e170ea
Show file tree

Hide file tree

Showing 11 changed files with 1,693 additions and 12 deletions.
diff --git a/packages/perf/__tests__/perf.test.ts b/packages/perf/__tests__/perf.test.ts
@@ -13,10 +13,10 @@ describe('Performance Monitoring', function () {
 
   describe('setPerformanceCollectionEnabled', function () {
     it('errors if not boolean', function () {
-      expect(() => {
+      expect(async () => {
         // @ts-ignore
-        perf().setPerformanceCollectionEnabled();
-      }).toThrow('must be a boolean');
+        await perf().setPerformanceCollectionEnabled();
+      }).rejects.toThrow('must be a boolean');
     });
   });
 
@@ -109,7 +109,7 @@ describe('Performance Monitoring', function () {
     it('errors if not boolean', async function () {
       try {
         // @ts-ignore
-        firebase.perf().setPerformanceCollectionEnabled();
+        await firebase.perf().setPerformanceCollectionEnabled();
         return Promise.reject(new Error('Did not throw'));
       } catch (e: any) {
         expect(e.message).toEqual(

diff --git a/...es/perf/android/src/main/java/io/invertase/firebase/perf/UniversalFirebasePerfModule.java b/...es/perf/android/src/main/java/io/invertase/firebase/perf/UniversalFirebasePerfModule.java
@@ -55,6 +55,9 @@ public Map<String, Object> getConstants() {
     constants.put(
         "isPerformanceCollectionEnabled",
         FirebasePerformance.getInstance().isPerformanceCollectionEnabled());
+        constants.put(
+          "isInstrumentationEnabled",
+          true);    
     return constants;
   }