feat(ios): allow static_framework usage via Podfile global (#3388)

First pass at addressing #3253 to allow release in 6.4.0. For v7.0.0 we should make the default value true along with the RN min version set to 0.61.x +
invertase · Apr 2, 2020 · 530f8bb · 530f8bb
1 parent 8adef65
commit 530f8bb
Show file tree

Hide file tree

Showing 20 changed files with 390 additions and 210 deletions.
diff --git a/packages/admob/RNFBAdMob.podspec b/packages/admob/RNFBAdMob.podspec
@@ -2,14 +2,10 @@ require 'json'
 package = JSON.parse(File.read(File.join(__dir__, 'package.json')))
 
 firebase_sdk_version = '~> 6.13.0'
-using_custom_firebase_sdk_version = defined? $FirebaseSDKVersion
-if using_custom_firebase_sdk_version
-  Pod::UI.puts "RNFBAdMob: Using user specified Firebase SDK version '#{$FirebaseSDKVersion}'"
-  firebase_sdk_version = $FirebaseSDKVersion
-end
 
 Pod::Spec.new do |s|
   s.name                = "RNFBAdMob"
+
   s.version             = package["version"]
   s.description         = package["description"]
   s.summary             = <<-DESC
@@ -22,11 +18,28 @@ Pod::Spec.new do |s|
   s.social_media_url    = 'http://twitter.com/invertaseio'
   s.ios.deployment_target = "9.0"
   s.source_files        = 'ios/**/*.{h,m}'
+
+  # React Native dependencies
   s.dependency          'React'
+  s.dependency          'RNFBApp'
+
+  # Other dependencies
+  s.dependency          'PersonalizedAdConsent', '~> 1.0.4'
+
+  if defined?($FirebaseSDKVersion)
+    Pod::UI.puts "#{s.name}: Using user specified Firebase SDK version '#{$FirebaseSDKVersion}'"
+    firebase_sdk_version = $FirebaseSDKVersion
+  end
+
+  # Firebase dependencies
   s.dependency          'Firebase/Core', firebase_sdk_version
   s.dependency          'Firebase/Analytics', firebase_sdk_version
   s.dependency          'Firebase/AdMob', firebase_sdk_version
-  s.dependency          'PersonalizedAdConsent'
-  s.dependency          'RNFBApp'
-  s.static_framework    = true
+
+  if defined?($RNFirebaseAsStaticFramework)
+    Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
+    s.static_framework = $RNFirebaseAsStaticFramework
+  else
+    s.static_framework = false
+  end
 end
diff --git a/packages/analytics/RNFBAnalytics.podspec b/packages/analytics/RNFBAnalytics.podspec
@@ -2,11 +2,6 @@ require 'json'
 package = JSON.parse(File.read(File.join(__dir__, 'package.json')))
 
 firebase_sdk_version = '~> 6.13.0'
-using_custom_firebase_sdk_version = defined? $FirebaseSDKVersion
-if using_custom_firebase_sdk_version
-  Pod::UI.puts "RNFBAnalytics: Using user specified Firebase SDK version '#{$FirebaseSDKVersion}'"
-  firebase_sdk_version = $FirebaseSDKVersion
-end
 
 Pod::Spec.new do |s|
   s.name                = "RNFBAnalytics"
@@ -22,8 +17,24 @@ Pod::Spec.new do |s|
   s.social_media_url    = 'http://twitter.com/invertaseio'
   s.ios.deployment_target = "9.0"
   s.source_files        = 'ios/**/*.{h,m}'
+
+  # React Native dependencies
   s.dependency          'React'
-  s.dependency          'Firebase/Core', firebase_sdk_version
   s.dependency          'RNFBApp'
-  s.static_framework    = false
+
+  if defined?($FirebaseSDKVersion)
+    Pod::UI.puts "#{s.name}: Using user specified Firebase SDK version '#{$FirebaseSDKVersion}'"
+    firebase_sdk_version = $FirebaseSDKVersion
+  end
+
+  # Firebase dependencies
+  s.dependency          'Firebase/Core', firebase_sdk_version
+  s.dependency          'Firebase/Analytics', firebase_sdk_version
+
+  if defined?($RNFirebaseAsStaticFramework)
+    Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
+    s.static_framework = $RNFirebaseAsStaticFramework
+  else
+    s.static_framework = false
+  end
 end
diff --git a/packages/app/RNFBApp.podspec b/packages/app/RNFBApp.podspec
@@ -3,11 +3,6 @@ require './firebase_json'
 package = JSON.parse(File.read(File.join(__dir__, 'package.json')))
 
 firebase_sdk_version = '~> 6.13.0'
-using_custom_firebase_sdk_version = defined? $FirebaseSDKVersion
-if using_custom_firebase_sdk_version
-  Pod::UI.puts "RNFBApp: Using user specified Firebase SDK version '#{$FirebaseSDKVersion}'"
-  firebase_sdk_version = $FirebaseSDKVersion
-end
 
 Pod::Spec.new do |s|
   s.name                = "RNFBApp"
@@ -23,7 +18,22 @@ Pod::Spec.new do |s|
   s.social_media_url    = 'http://twitter.com/invertaseio'
   s.ios.deployment_target = "9.0"
   s.source_files        = "ios/**/*.{h,m}"
+
+  # React Native dependencies
   s.dependency          'React'
+
+  if defined?($FirebaseSDKVersion)
+    Pod::UI.puts "#{s.name}: Using user specified Firebase SDK version '#{$FirebaseSDKVersion}'"
+    firebase_sdk_version = $FirebaseSDKVersion
+  end
+
+  # Firebase dependencies
   s.dependency          'Firebase/Core', firebase_sdk_version
-  s.static_framework    = false
+
+  if defined?($RNFirebaseAsStaticFramework)
+    Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
+    s.static_framework = $RNFirebaseAsStaticFramework
+  else
+    s.static_framework = false
+  end
 end
diff --git a/packages/auth/RNFBAuth.podspec b/packages/auth/RNFBAuth.podspec
@@ -2,11 +2,6 @@ require 'json'
 package = JSON.parse(File.read(File.join(__dir__, 'package.json')))
 
 firebase_sdk_version = '~> 6.13.0'
-using_custom_firebase_sdk_version = defined? $FirebaseSDKVersion
-if using_custom_firebase_sdk_version
-  Pod::UI.puts "RNFBAuth: Using user specified Firebase SDK version '#{$FirebaseSDKVersion}'"
-  firebase_sdk_version = $FirebaseSDKVersion
-end
 
 Pod::Spec.new do |s|
   s.name                = "RNFBAuth"
@@ -22,9 +17,24 @@ Pod::Spec.new do |s|
   s.social_media_url    = 'http://twitter.com/invertaseio'
   s.ios.deployment_target = "9.0"
   s.source_files        = 'ios/**/*.{h,m}'
+
+  # React Native dependencies
   s.dependency          'React'
+  s.dependency          'RNFBApp'
+
+  if defined?($FirebaseSDKVersion)
+    Pod::UI.puts "#{s.name}: Using user specified Firebase SDK version '#{$FirebaseSDKVersion}'"
+    firebase_sdk_version = $FirebaseSDKVersion
+  end
+
+  # Firebase dependencies
   s.dependency          'Firebase/Core', firebase_sdk_version
   s.dependency          'Firebase/Auth', firebase_sdk_version
-  s.dependency          'RNFBApp'
-  s.static_framework    = false
+
+  if defined?($RNFirebaseAsStaticFramework)
+    Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
+    s.static_framework = $RNFirebaseAsStaticFramework
+  else
+    s.static_framework = false
+  end
 end
diff --git a/packages/crashlytics/RNFBCrashlytics.podspec b/packages/crashlytics/RNFBCrashlytics.podspec
@@ -3,27 +3,12 @@ package = JSON.parse(File.read(File.join(__dir__, 'package.json')))
 
 # Firebase SDK Override
 firebase_sdk_version = '~> 6.13.0'
-using_custom_firebase_sdk_version = defined? $FirebaseSDKVersion
-if using_custom_firebase_sdk_version
-  Pod::UI.puts "RNFBCrashlytics: Using user specified Firebase SDK version '#{$FirebaseSDKVersion}'"
-  firebase_sdk_version = $FirebaseSDKVersion
-end
 
 # Fabric SDK Override
 fabric_sdk_version = '~> 1.10.2'
-using_custom_fabric_sdk_version = defined? $FabricSDKVersion
-if using_custom_fabric_sdk_version
-  Pod::UI.puts "RNFBCrashlytics: Using user specified Fabric SDK version '#{$FabricSDKVersion}'"
-  fabric_sdk_version = $FabricSDKVersion
-end
 
 # Crashlytics SDK Override
 crashlytics_sdk_version = '~> 3.14.0'
-using_custom_crashlytics_sdk_version = defined? $CrashlyticsSDKVersion
-if using_custom_crashlytics_sdk_version
-  Pod::UI.puts "RNFBCrashlytics: Using user specified Crashlytics SDK version '#{$CrashlyticsSDKVersion}'"
-  crashlytics_sdk_version = $CrashlyticsSDKVersion
-end
 
 Pod::Spec.new do |s|
   s.name                = "RNFBCrashlytics"
@@ -39,10 +24,36 @@ Pod::Spec.new do |s|
   s.social_media_url    = 'http://twitter.com/invertaseio'
   s.ios.deployment_target = "9.0"
   s.source_files        = 'ios/**/*.{h,m}'
+
+  # React Native dependencies
   s.dependency          'React'
+  s.dependency          'RNFBApp'
+
+  if defined?($FirebaseSDKVersion)
+    Pod::UI.puts "#{s.name}: Using user specified Firebase SDK version '#{$FirebaseSDKVersion}'"
+    firebase_sdk_version = $FirebaseSDKVersion
+  end
+
+  if defined?($CrashlyticsSDKVersion)
+    Pod::UI.puts "#{s.name}: Using user specified Crashlytics SDK version '#{$CrashlyticsSDKVersion}'"
+    crashlytics_sdk_version = $CrashlyticsSDKVersion
+  end
+
+  if defined?($FabricSDKVersion)
+    Pod::UI.puts "#{s.name}: Using user specified Fabric SDK version '#{$FabricSDKVersion}'"
+    fabric_sdk_version = $FabricSDKVersion
+  end
+
+  # Firebase dependencies
   s.dependency          'Fabric', fabric_sdk_version
   s.dependency          'Firebase/Core', firebase_sdk_version
   s.dependency          'Crashlytics', crashlytics_sdk_version
-  s.dependency          'RNFBApp'
-  s.static_framework    = false
+
+  if defined?($RNFirebaseAsStaticFramework)
+    Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
+    s.static_framework = $RNFirebaseAsStaticFramework
+  else
+    s.static_framework = false
+  end
+
 end
diff --git a/packages/database/RNFBDatabase.podspec b/packages/database/RNFBDatabase.podspec
@@ -2,11 +2,6 @@ require 'json'
 package = JSON.parse(File.read('./package.json'))
 
 firebase_sdk_version = '~> 6.13.0'
-using_custom_firebase_sdk_version = defined? $FirebaseSDKVersion
-if using_custom_firebase_sdk_version
-  Pod::UI.puts "RNFBDatabase: Using user specified Firebase SDK version '#{$FirebaseSDKVersion}'"
-  firebase_sdk_version = $FirebaseSDKVersion
-end
 
 Pod::Spec.new do |s|
   s.name                = "RNFBDatabase"
@@ -22,9 +17,24 @@ Pod::Spec.new do |s|
   s.social_media_url    = 'http://twitter.com/invertaseio'
   s.ios.deployment_target = "9.0"
   s.source_files        = 'ios/**/*.{h,m}'
+
+  # React Native dependencies
   s.dependency          'React'
+  s.dependency          'RNFBApp'
+
+  if defined?($FirebaseSDKVersion)
+    Pod::UI.puts "#{s.name}: Using user specified Firebase SDK version '#{$FirebaseSDKVersion}'"
+    firebase_sdk_version = $FirebaseSDKVersion
+  end
+
+  # Firebase dependencies
   s.dependency          'Firebase/Core', firebase_sdk_version
   s.dependency          'Firebase/Database', firebase_sdk_version
-  s.dependency          'RNFBApp'
-  s.static_framework    = false
+
+  if defined?($RNFirebaseAsStaticFramework)
+    Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
+    s.static_framework = $RNFirebaseAsStaticFramework
+  else
+    s.static_framework = false
+  end
 end
diff --git a/packages/dynamic-links/RNFBDynamicLinks.podspec b/packages/dynamic-links/RNFBDynamicLinks.podspec
@@ -2,11 +2,6 @@ require 'json'
 package = JSON.parse(File.read(File.join(__dir__, 'package.json')))
 
 firebase_sdk_version = '~> 6.13.0'
-using_custom_firebase_sdk_version = defined? $FirebaseSDKVersion
-if using_custom_firebase_sdk_version
-  Pod::UI.puts "RNFBDynamicLinks: Using user specified Firebase SDK version '#{$FirebaseSDKVersion}'"
-  firebase_sdk_version = $FirebaseSDKVersion
-end
 
 Pod::Spec.new do |s|
   s.name                = "RNFBDynamicLinks"
@@ -22,9 +17,24 @@ Pod::Spec.new do |s|
   s.social_media_url    = 'http://twitter.com/invertaseio'
   s.ios.deployment_target = "9.0"
   s.source_files        = 'ios/**/*.{h,m}'
+
+  # React Native dependencies
   s.dependency          'React'
+  s.dependency          'RNFBApp'
+
+  if defined?($FirebaseSDKVersion)
+    Pod::UI.puts "#{s.name}: Using user specified Firebase SDK version '#{$FirebaseSDKVersion}'"
+    firebase_sdk_version = $FirebaseSDKVersion
+  end
+
+  # Firebase dependencies
   s.dependency          'Firebase/Core', firebase_sdk_version
   s.dependency          'Firebase/DynamicLinks', firebase_sdk_version
-  s.dependency          'RNFBApp'
-  s.static_framework    = false
+
+  if defined?($RNFirebaseAsStaticFramework)
+    Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
+    s.static_framework = $RNFirebaseAsStaticFramework
+  else
+    s.static_framework = false
+  end
 end
diff --git a/packages/firestore/RNFBFirestore.podspec b/packages/firestore/RNFBFirestore.podspec
@@ -2,11 +2,6 @@ require 'json'
 package = JSON.parse(File.read(File.join(__dir__, 'package.json')))
 
 firebase_sdk_version = '~> 6.13.0'
-using_custom_firebase_sdk_version = defined? $FirebaseSDKVersion
-if using_custom_firebase_sdk_version
-  Pod::UI.puts "RNFBDynamicLinks: Using user specified Firebase SDK version '#{$FirebaseSDKVersion}'"
-  firebase_sdk_version = $FirebaseSDKVersion
-end
 
 Pod::Spec.new do |s|
   s.name                = "RNFBFirestore"
@@ -22,9 +17,24 @@ Pod::Spec.new do |s|
   s.social_media_url    = 'http://twitter.com/invertaseio'
   s.ios.deployment_target = "9.0"
   s.source_files        = 'ios/**/*.{h,m}'
+
+  # React Native dependencies
   s.dependency          'React'
+  s.dependency          'RNFBApp'
+
+  if defined?($FirebaseSDKVersion)
+    Pod::UI.puts "#{s.name}: Using user specified Firebase SDK version '#{$FirebaseSDKVersion}'"
+    firebase_sdk_version = $FirebaseSDKVersion
+  end
+
+  # Firebase dependencies
   s.dependency          'Firebase/Core', firebase_sdk_version
   s.dependency          'Firebase/Firestore', firebase_sdk_version
-  s.dependency          'RNFBApp'
-  s.static_framework    = false
+
+  if defined?($RNFirebaseAsStaticFramework)
+    Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
+    s.static_framework = $RNFirebaseAsStaticFramework
+  else
+    s.static_framework = false
+  end
 end
diff --git a/packages/functions/RNFBFunctions.podspec b/packages/functions/RNFBFunctions.podspec
@@ -2,11 +2,6 @@ require 'json'
 package = JSON.parse(File.read(File.join(__dir__, 'package.json')))
 
 firebase_sdk_version = '~> 6.13.0'
-using_custom_firebase_sdk_version = defined? $FirebaseSDKVersion
-if using_custom_firebase_sdk_version
-  Pod::UI.puts "RNFBFirestore: Using user specified Firebase SDK version '#{$FirebaseSDKVersion}'"
-  firebase_sdk_version = $FirebaseSDKVersion
-end
 
 Pod::Spec.new do |s|
   s.name                = "RNFBFunctions"
@@ -22,8 +17,24 @@ Pod::Spec.new do |s|
   s.social_media_url    = 'http://twitter.com/invertaseio'
   s.ios.deployment_target = "9.0"
   s.source_files        = 'ios/**/*.{h,m}'
+
+  # React Native dependencies
   s.dependency          'React'
-  s.dependency          'Firebase/Functions', firebase_sdk_version
   s.dependency          'RNFBApp'
-  s.static_framework    = false
+
+  if defined?($FirebaseSDKVersion)
+    Pod::UI.puts "#{s.name}: Using user specified Firebase SDK version '#{$FirebaseSDKVersion}'"
+    firebase_sdk_version = $FirebaseSDKVersion
+  end
+
+  # Firebase dependencies
+  s.dependency          'Firebase/Core', firebase_sdk_version
+  s.dependency          'Firebase/Functions', firebase_sdk_version
+
+  if defined?($RNFirebaseAsStaticFramework)
+    Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
+    s.static_framework = $RNFirebaseAsStaticFramework
+  else
+    s.static_framework = false
+  end
 end