🔥 [firestore] update with FieldPath doesn't deep merge

[iwikal]

Issue

When specifying a field path with a firestore.FieldPath instead of a string, both WriteBatch.update and DocumentReference.update fails to deep merge. For instance, given this document:

firestore().doc('test/test').set({
  myMap: {
    initialKey: 'initialValue',
  },
  separateField: 'x',
})

...the following code...

firestore().doc('test/test')
  .update('myMap.newKey', 'newValue')

...does exactly what I expect:

{
  "myMap": {
    "initialKey": "initialValue",
    "newKey": "newValue"
  },
  "separateField": "x"
}

But this code does something unexpected!

firestore()
  .doc('test/test')
  .update(new firestore.FieldPath('myMap', 'newKey'), 'newValue')

Result:

{
  "myMap": {
    "newKey": "newValue"
  },
  "separateField": "x"
}

Note that the inital value in the map is gone, but the separate field remains. I tried the same thing with the firebase-admin sdk, and got the expected behaviour.

---

Project Files

iOS

Click To Expand

ios/Podfile:

• I'm not using Pods
• I'm using Pods and my Podfile looks like:

# N/A

AppDelegate.m:

// N/A

---

Android

Click To Expand

Have you converted to AndroidX?

• my application is an AndroidX application?
• I am using android/gradle.settings jetifier=true for Android compatibility?
• I am using the NPM package jetifier for react-native compatibility?

android/build.gradle:

// N/A

android/app/build.gradle:

// N/A

android/settings.gradle:

// N/A

MainApplication.java:

// N/A

AndroidManifest.xml:

<!-- N/A -->

---

Environment

Click To Expand

react-native info output:

info Fetching system and libraries information...
System:
    OS: Linux 4.15 Ubuntu 18.04.3 LTS (Bionic Beaver)
    CPU: (4) x64 Intel(R) Core(TM) i5-7200U CPU @ 2.50GHz
    Memory: 2.61 GB / 15.55 GB
    Shell: 5.4.2 - /usr/bin/zsh
  Binaries:
    Node: 10.16.2 - ~/.nvm/versions/node/v10.16.2/bin/node
    Yarn: 1.17.3 - ~/.yarn/bin/yarn
    npm: 6.10.3 - ~/.nvm/versions/node/v10.16.2/bin/npm
  npmPackages:
    @react-native-community/cli: ^2.8.0 => 2.8.0 
    react: 16.8.6 => 16.8.6 
    react-native: 0.60.4 => 0.60.4

• Platform that you're experiencing the issue on:
  • iOS
  • Android
  • iOS but have not tested behavior on Android
  • Android but have not tested behavior on iOS
  • Both
• react-native-firebase version you're using that has this issue:
  • 5.5.6
• Firebase module(s) you're using that has the issue:
  • Firestore
• Are you using TypeScript?
  • Y

---

Think react-native-firebase is great? Please consider supporting all of the project maintainers and contributors by donating via our Open Collective where all contributors can submit expenses. [Learn More]

• 👉 Check out React Native Firebase and Invertase on Twitter for updates on the library.

[Ehesp]

Interesting - thanks for the detailed report. I'll get this looked into.

[stale]

Hello 👋, to help manage issues we automatically close stale issues.
This issue has been automatically marked as stale because it has not had activity for quite some time. Has this issue been fixed, or does it still require the community's attention?

This issue will be closed in 15 days if no further activity occurs.
Thank you for your contributions.

[Ehesp]

Thanks for reporting. Turns out the fix was simple one! For some reason it was overcomplicating FieldPaths, trying to merge objects together when it can just pass the dot notated paths to native land.

[Salakar]

Hey 👋 this issue should now be fixed in v6.0.1, thanks. [release notes]