Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdks, android)!: firebase-android-sdk v29 / minSdkVersion API19 / target+compile API31 #5825

Merged
merged 3 commits into from
Oct 31, 2021

Conversation

mikehardy
Copy link
Collaborator

Description

  • increase our compatibility up to target/compile SDK 31 - this has no impact on library consumers
  • increase firebase-android-sdk to v29, this is a breaking change and requires consumers to update their apps to minSdkVersion 19 (as required in underlying react-native 0.64+)

Release Summary

Conventional commits on each one, carefully set up so the breaking change version and notes should go out automatically with useful details

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Each commit tested locally, should work in CI as well


Think react-native-firebase is great? Please consider supporting the project with any of the below:

BREAKING CHANGE: firebase-android-sdk 29 requires android/build.gradle minSdkVersion 19 (as required in react-native 0.64+)
@vercel
Copy link

vercel bot commented Oct 31, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

react-native-firebase – ./

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/AVG54dgSMnapXnfj2NmjBTqKQ2B7
✅ Preview: https://react-native-firebase-git-mikehardy-android-sdk-29-invertase.vercel.app

react-native-firebase-next – ./website_modular

🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/C5wXjzzWt4seQF3ZZU4VB6n2KfH6
✅ Preview: Canceled

@codecov
Copy link

codecov bot commented Oct 31, 2021

Codecov Report

Merging #5825 (631a215) into main (2c1958e) will not change coverage.
The diff coverage is n/a.

❗ Current head 631a215 differs from pull request most recent head 5dd2c80. Consider uploading reports for the commit 5dd2c80 to get more accurate results

@@            Coverage Diff            @@
##               main    #5825   +/-   ##
=========================================
  Coverage     52.98%   52.98%           
  Complexity      620      620           
=========================================
  Files           208      208           
  Lines         10118    10118           
  Branches       1589     1589           
=========================================
  Hits           5360     5360           
  Misses         4503     4503           
  Partials        255      255           

@mikehardy mikehardy added Workflow: Pending Merge Waiting on CI or similar and removed Workflow: Pending Merge Waiting on CI or similar labels Oct 31, 2021
@mikehardy mikehardy merged commit f60afe1 into main Oct 31, 2021
@mikehardy mikehardy deleted the @mikehardy/android-sdk-29 branch October 31, 2021 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant