Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(analytics): expose native automatic screenview reporting toggle #5948

Merged
merged 6 commits into from
Dec 18, 2021

Conversation

se09deluca
Copy link
Contributor

@se09deluca se09deluca commented Dec 18, 2021

Description

See related issue comment

Automatic screenview tracking can now be disabled/enabled via firebase.json throught "google_analytics_automatic_screen_reporting_enabled" property.

Automatic screenview reporting (enabled by default) previously could not be disabled trought firebase.json configuration file, but only adding the meta tag in AndroidManifest.xml or Info.plist key (the native way).
This commit includes the needed adds in build.gradle and ios_config.sh to make these config exposed to the react native project.

Release Summary

Includes google_analytics_automatic_screen_reporting_enabled in firebase.json properties

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • This is a breaking change;
    • Yes
    • No

Automatic screenview tracking can now be disabled/enabled via firebase.json through "google_analytics_automatic_screen_reporting_enabled" property.
@vercel
Copy link

vercel bot commented Dec 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

react-native-firebase – ./

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/58kAn6gkyBEnRj2N8iLZPczmn2Wm
✅ Preview: https://react-native-firebase-git-fork-se09deluca-main-invertase.vercel.app

react-native-firebase-next – ./website_modular

🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/7U5QYtRtgMBQwgR6F5w1M6BjjGGo
✅ Preview: Canceled

[Deployment for 29a8600 canceled]

@CLAassistant
Copy link

CLAassistant commented Dec 18, 2021

CLA assistant check
All committers have signed the CLA.

mikehardy
mikehardy previously approved these changes Dec 18, 2021
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perfect first time! Thank you. I've got two other fixes just merged, hopefully CI goes green on this and I'll release it today

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Dec 18, 2021
@codecov
Copy link

codecov bot commented Dec 18, 2021

Codecov Report

Merging #5948 (057e8fc) into main (a5a8270) will decrease coverage by 27.60%.
The diff coverage is n/a.

❗ Current head 057e8fc differs from pull request most recent head 29a8600. Consider uploading reports for the commit 29a8600 to get more accurate results

@@              Coverage Diff              @@
##               main    #5948       +/-   ##
=============================================
- Coverage     53.04%   25.45%   -27.59%     
=============================================
  Files           208       97      -111     
  Lines         10171     4245     -5926     
  Branches       1618     1033      -585     
=============================================
- Hits           5394     1080     -4314     
+ Misses         4523     2571     -1952     
- Partials        254      594      +340     

@mikehardy
Copy link
Collaborator

Nothing at all wrong with the implementation - I just shepherded it through the trivial lint line-spacing / spellchecking crud 😄 --> merged! 🚀

@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Dec 18, 2021
@se09deluca
Copy link
Contributor Author

Thanks a lot!
It has been my first contribution, I’m not expert on this. Next time I’ll surely give more attention!
🙏🏻☺️

@Jbug1984
Copy link

Jbug1984 commented Dec 18, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants