Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle wrapper 4.4 transitive = false no longer works #861

Closed
sgong-pdftron opened this issue Mar 3, 2018 · 3 comments
Closed

Gradle wrapper 4.4 transitive = false no longer works #861

sgong-pdftron opened this issue Mar 3, 2018 · 3 comments
Labels
Help: Needs Triage Issue needs additional investigation/triaging. Impact: Build Error Behaviour causing build failure Platform: Android

Comments

@sgong-pdftron
Copy link

Issue

Gradle wrapper 4.4 "transitive = false" no longer works.
All modules that are not referenced in the main application will not compile. Have to manually comment out all modules not in use.

Environment

Android

  1. Application Target Platform:
    Windows 10
  1. Development Operating System:
    Android Studio v3.0.1
  1. Build Tools:
    27.0.3
  1. React Native version:
    0.49.+
  1. RNFirebase Version:
    3.2.7
  1. Firebase Module:
    any

After migrated to Android Plugin for Gradle 3.0.0 (https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration.html), using gradle wrapper version 4.4, transitive project dependency no longer works.

Before forced to update to gradle wrapper 4.4, it was working fine, however, after being forced to update to gradle wrapper 4.4 by Android Studio, I have to manually comment out all the modules that I am not using in the main project, or set transitive to true, i.e.

Does not work:

implementation(project(':react-native-firebase')) {
        transitive = false
}

Works (however I am only using a few modules and may not want to pull in all modules):

implementation(project(':react-native-firebase')) {
        transitive = true
}

Any help is highly appreciated! Thanks.

@Salakar Salakar added Platform: Android Impact: Build Error Behaviour causing build failure Help: Needs Triage Issue needs additional investigation/triaging. labels Mar 5, 2018
@Salakar
Copy link
Member

Salakar commented Mar 13, 2018

@sgong-pdftron looking at the Gradle 4.4 api docs I can't see why this would no longer work - it still has transitive support. Can you try api instead of implementation

@Salakar Salakar added the Workflow: Waiting for User Response Blocked waiting for user response. label Mar 13, 2018
@sgong-pdftron
Copy link
Author

@Salakar thanks for the reply! Unfortunately api does not work as well...

Not sure if it helps, but this is the error I get. I am not using ads module.

image

@chrisbianca chrisbianca removed the Workflow: Waiting for User Response Blocked waiting for user response. label Mar 22, 2018
@chrisbianca
Copy link
Contributor

Closing in favour of #915

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help: Needs Triage Issue needs additional investigation/triaging. Impact: Build Error Behaviour causing build failure Platform: Android
Projects
None yet
Development

No branches or pull requests

3 participants