Failed to find byte code for com/google/firebase [any unused module] #915

xzilja · 2018-03-27T17:10:07Z

Issue

I upgraded to android studio 3.1 today and gradle 3.1 that came out and started getting these errors

Failed to find byte code for com/google/android/gms/ads/VideoController$VideoLifecycleCallbacks

Failed to find byte code for com/google/firebase/storage/StreamDownloadTask$StreamProcessor

Failed to find byte code for com/google/firebase/database/ChildEventListener

etc... all of these are firebase modules I currently don't use in my project i.e I don't have anything like

compile 'com.google.firebase:firebase-database:11.8.0'

in my app/build.gradle as I don't use it. I also submitted a question at stack overflow regarding this: https://stackoverflow.com/questions/49518556/failed-to-find-byte-code-for-com-google-firebase

Where they suggested to actually include any erorring modules and this does indeed fix the issue, but I had to add a ton of them, which I don't think is necessary?

Fact that this happens to almost all firebase dependencies that I don't use and can only assume are used in RNFirebase I think this is an issue?

Environment

Application Target Platform: Android

Development Operating System: macOS High Siera

Build Tools: Android Studio 3.1, Android SDK 26, com.android.tools.build:gradle:3.1.0

React Native version: 0.54.3

RNFirebase Version: 3.3.1

Firebase Module: Any unused module

The text was updated successfully, but these errors were encountered:

chrisbianca · 2018-03-28T15:03:41Z

@iljadaderko any chance you could try the latest code from master and see whether its fixed? Just did some changes to migrate to the new Gradle dependency configurations: 7f7169b

Alternatively, try making the equivalent changes locally to see if it fixes the issue...

xzilja · 2018-03-28T15:06:45Z

@chrisbianca will give it a shot as soon as I am done with my main work. Could be related to compile being deprecated.

When we include firebase modules in our own projects, I assume we should use implementation instead of compile?

chrisbianca · 2018-03-28T15:08:26Z

Great, thanks. Yeah, I've switched our tests app over to using implementation and this seems to work. Although I couldn't actually reproduce the errors you were seeing to be able to confirm it's fixed your problem.

xzilja · 2018-03-28T15:13:11Z

There was one other guy in Stack Overflow question I mentioned having same issues with 3.3 after upgrading to latest gradle by the way.

xzilja · 2018-03-28T15:21:27Z

@chrisbianca ok, so I basically swapped android/build.gradle in my node_modules with your change and it got past that error 👍

I'm not sure if this is already fixed in v4 but now this is popping up

error: RNFirebaseAdMobRewardedVideo is not abstract and does not override abstract method onRewardedVideoCompleted() in RewardedVideoAdListener

I'm not using adMob module in project, so not sure if its still related to this issue. Let me know if I should close and open another one.

I will run v4 this weekend to see if it fixes these issues, as there are few things I need to change according to the docs to make it work.

chrisbianca · 2018-03-28T15:22:27Z

Awesome, thanks for the confirmation!

Yes, that is fixed in v4 - it's a result of some API changes in v12 of the Firebase Android libs

xzilja · 2018-03-28T15:22:42Z

As a side note, my project has all changes you made to test app as well, so if yours is working on v4, I think mine will as well 👍

chrisbianca · 2018-03-28T15:42:41Z

We're going to get another RC of v4 out shortly - once we have, we'll close this issue off.

We're unlikely to backport this to v3 due to the complications with getting it working across multiple gradle versions.

chrisbianca · 2018-03-28T16:33:03Z

v4.0.0-rc.3 is out now.

Check out the release notes for instructions on how to upgrade gradle: https://github.com/invertase/react-native-firebase/releases/tag/v4.0.0-rc.3

xzilja · 2018-03-29T10:32:34Z

@chrisbianca I updated my project to v4.0.0-rc.3 just now, started getting these errors again.
As this didn't make much sense to me I tired to reset all caches I can think of

Deleted my projects /build, .iml files
Deleted /.gradle folder from my macs home dir
Reinstalled my node modules (deleted them, deleted package-lock, ran npm cache verify)

And am still getting the error

I went and compared build.gradle from rc3 that I have in android studio with changes you referenced 7f7169b, everything is identical.

My next step was to compare my android setup with your test app setup and there is one difference, but nothing I can see that would cause this, I have com.google.gms:google-services:3.2.0 (I tried to use 3.1.2 as in test app to be sure, didn't make a change)

My dependencies are

dependencies {
    implementation fileTree(include: ["*.jar"], dir: "libs")
    implementation "com.android.support:appcompat-v7:27.1.0"
    implementation "com.google.android.gms:play-services-base:12.0.0"
    implementation "com.google.android.gms:play-services-auth:12.0.0"
    implementation "com.google.firebase:firebase-core:12.0.0"
    implementation "com.google.firebase:firebase-auth:12.0.0"
    implementation "com.google.firebase:firebase-firestore:12.0.0"
    implementation "com.google.firebase:firebase-invites:12.0.0"
    implementation "com.google.firebase:firebase-messaging:12.0.0"
    implementation "com.facebook.react:react-native:+"
    implementation project(":react-native-device-info")
    implementation project(":react-native-fbsdk")
    implementation(project(":rn-google-sign-in")){
        exclude group: "com.google.android.gms"
    }
    implementation(project(":react-native-firebase")) {
        transitive = false
    }
}

I am currently getting errors related to database / adMob etc.. all modules I don't use

Failed to find byte code for com/google/firebase/storage/OnPausedListener

xzilja · 2018-03-30T07:37:04Z

And as expected it all worked once I added (not propper solution however, correct?)

    // Don't need these
    implementation "com.google.firebase:firebase-ads:12.0.1"
    implementation "com.google.firebase:firebase-config:12.0.1"
    implementation "com.google.firebase:firebase-crash:12.0.1"
    implementation "com.google.firebase:firebase-database:12.0.1"
    implementation "com.google.firebase:firebase-perf:12.0.1"
    implementation "com.google.firebase:firebase-storage:12.0.1"
    // END Don't need these

chrisbianca · 2018-04-04T09:53:49Z

@iljadaderko It looks like this is a known issue in 3.1 :( https://issuetracker.google.com/issues/72811718

If you disable instant run this should start working for you again.

xzilja · 2018-04-04T11:13:25Z

Gotcha, thank you for bug reference, shame they released with this :/

chrisbianca · 2018-04-04T11:17:22Z

Isn't it just! Pretty poor tbh, essentially breaking any library that's correctly specifying compileOnly dependencies.

We'll make sure we include it in the upgrade / migration notes. I think if you run from the command line, this won't be an issue, it's only if you go through Android Studio.

xzilja · 2018-04-04T11:19:20Z

Yeh, it seems its related to their "Instant Run" functionality, that can be disabled. Will make rebuilding apps a bit slower however, might be a good alternative instead of including all missing libs for some people.

MultidimensionalLife · 2018-04-20T08:10:23Z

Same issue here. Any fixes for this?

xzilja · 2018-04-20T08:17:25Z

@sequencer08 3 options

Disable instant run in android studio
Add all firebase modules
Upgrade to gradle 3.1.1

MultidimensionalLife · 2018-04-20T16:34:06Z

Hi @iljadaderko, Thanks for the suggestion. I able to fixed the issue by including all the firebase modules since I already upgraded the gradle to 3.1.1. But is there any option except including all firebase modules? For me, I think It's not necessary to include what I'm not using. Big thanks 😄

xzilja · 2018-04-20T16:53:54Z

@sequencer08 honestly I'd just disable instant run in android studio, its not needed for react native projects imho. Googling how to do so should solve your issue 👍 Its android studio specific, when you build with cli you won't see the issue.

zkrige · 2018-06-11T13:00:39Z

Disabling instant run fixed this

EKoetsjarjan · 2018-12-17T15:39:47Z

Failed to find byte code for com/google/firebase/database/DatabaseReference$CompletionListener

disabling instant run fixed it for for me too (android studio 3.2.1)

artyom-developer · 2019-05-29T14:19:59Z

same bugs :( help

Salakar added Platform: Android Impact: Build Error Behaviour causing build failure Help: Needs Triage Issue needs additional investigation/triaging. labels Mar 28, 2018

chrisbianca mentioned this issue Mar 28, 2018

Gradle wrapper 4.4 transitive = false no longer works #861

Closed

chrisbianca closed this as completed Mar 28, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Failed to find byte code for com/google/firebase [any unused module] #915

Failed to find byte code for com/google/firebase [any unused module] #915

xzilja commented Mar 27, 2018 •

edited

Loading

chrisbianca commented Mar 28, 2018

xzilja commented Mar 28, 2018

chrisbianca commented Mar 28, 2018

xzilja commented Mar 28, 2018

xzilja commented Mar 28, 2018

chrisbianca commented Mar 28, 2018

xzilja commented Mar 28, 2018

chrisbianca commented Mar 28, 2018

chrisbianca commented Mar 28, 2018

xzilja commented Mar 29, 2018 •

edited

Loading

xzilja commented Mar 30, 2018

chrisbianca commented Apr 4, 2018

xzilja commented Apr 4, 2018

chrisbianca commented Apr 4, 2018

xzilja commented Apr 4, 2018

MultidimensionalLife commented Apr 20, 2018

xzilja commented Apr 20, 2018

MultidimensionalLife commented Apr 20, 2018

xzilja commented Apr 20, 2018

zkrige commented Jun 11, 2018

EKoetsjarjan commented Dec 17, 2018

artyom-developer commented May 29, 2019

Failed to find byte code for com/google/firebase [any unused module] #915

Failed to find byte code for com/google/firebase [any unused module] #915

Comments

xzilja commented Mar 27, 2018 • edited Loading

Issue

Environment

chrisbianca commented Mar 28, 2018

xzilja commented Mar 28, 2018

chrisbianca commented Mar 28, 2018

xzilja commented Mar 28, 2018

xzilja commented Mar 28, 2018

chrisbianca commented Mar 28, 2018

xzilja commented Mar 28, 2018

chrisbianca commented Mar 28, 2018

chrisbianca commented Mar 28, 2018

xzilja commented Mar 29, 2018 • edited Loading

xzilja commented Mar 30, 2018

chrisbianca commented Apr 4, 2018

xzilja commented Apr 4, 2018

chrisbianca commented Apr 4, 2018

xzilja commented Apr 4, 2018

MultidimensionalLife commented Apr 20, 2018

xzilja commented Apr 20, 2018

MultidimensionalLife commented Apr 20, 2018

xzilja commented Apr 20, 2018

zkrige commented Jun 11, 2018

EKoetsjarjan commented Dec 17, 2018

artyom-developer commented May 29, 2019

xzilja commented Mar 27, 2018 •

edited

Loading

xzilja commented Mar 29, 2018 •

edited

Loading