Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage,ios): Handle null Storage metadata values #2881

Merged
merged 1 commit into from
Nov 17, 2019

Conversation

bcgilliom
Copy link

Summary

It seems that the metadata coming back from firebase is occasionally nil, which throws an exception in NSDictionary, so this probably just hides a deeper problem. But, it's better than crashing!

Checklist

  • Supports Android
  • Supports iOS
  • e2e tests added or updated in packages/**/e2e
  • Flow types updated
  • Typescript types updated

Test Plan

  • use Storage putFile on iOS, should not see a crash related to nil at object[1]
  • this was about a 1/5 bug for me, so reproducing might be tricky

Release Plan

[IOS ][BUGFIX ] [Storage] - fix occasional crash when uploading file with putFile


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Brian CG seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Nov 15, 2019

Codecov Report

Merging #2881 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2881      +/-   ##
==========================================
- Coverage   88.69%   88.68%   -<.01%     
==========================================
  Files         111      111              
  Lines        3437     3436       -1     
==========================================
- Hits         3048     3047       -1     
  Misses        389      389

Copy link
Member

@Salakar Salakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this looks like iOS code to me, approved!

@Salakar
Copy link
Member

Salakar commented Nov 17, 2019

Thanks for sending this fix over, will release shortly

@Salakar Salakar changed the title don't allow a null key in Storage metadata fix(storage,ios): Handle null Storage metadata values Nov 17, 2019
@Salakar Salakar merged commit eeb90c0 into invertase:master Nov 17, 2019
@Salakar Salakar added Service: Storage Firebase Cloud Storage Platform: iOS labels Nov 17, 2019
@Salakar Salakar added this to the v6.1.0 milestone Nov 17, 2019
@Salakar
Copy link
Member

Salakar commented Nov 17, 2019

This is now live in v6.0.4. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: iOS Service: Storage Firebase Cloud Storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants