Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firestore): onSnapshotsInSync API #4029

Closed
wants to merge 6 commits into from

Conversation

russellwheatley
Copy link
Member

Description

This is still draft for the time being as execution order is wrong for Android. Please ignore until PR is open.

  • new API for Firestore onSnapshotsInSync.
  • replaces defunct PR after I messed up the git history.

Related issues

None that I know of.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@russellwheatley russellwheatley changed the title feat(firestore): feat(firestore): onSnapshotsInSync API Jul 31, 2020
@russellwheatley
Copy link
Member Author

There's a problem with Android. The onSnapshotsInSync event is correctly fired after the onSnapshot event.

Screenshot 2020-08-03 at 14 58 49

But after the async operation of the snapshot serialisation, the onSnapshot event is emitted last:
Screenshot 2020-08-03 at 14 56 53

This manifests in the onSnapshotsInSync firing before the onSnapshot event on the JS side:
Screenshot 2020-08-03 at 14 47 51

We need to figure out a way to get the onSnapshotsInSync event to queue up behind the onSnapshot event.

@mikehardy mikehardy added the Workflow: Waiting for User Response Blocked waiting for user response. label Nov 10, 2020
@Salakar Salakar added the Service: Firestore Firebase Cloud Firestore label Apr 11, 2021
@Salakar Salakar closed this Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Service: Firestore Firebase Cloud Firestore Workflow: Waiting for User Response Blocked waiting for user response.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants