Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): bump firebase-ios-sdk dependency to 8.4.0 #5538

Merged
merged 1 commit into from Jul 21, 2021

Conversation

mikehardy
Copy link
Collaborator

Description

Standard native SDK bump

Release Summary

Conventional commit / PR title

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

CI only


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Jul 21, 2021
@vercel
Copy link

vercel bot commented Jul 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

react-native-firebase – ./

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/9CAZYND4UDuKRuzqGwobmWV1RwY8
✅ Preview: https://react-native-firebase-git-mikehardy-dependency-310d7b-invertase.vercel.app

react-native-firebase-next – ./website_modular

🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/6gRUpFYKLLoNvqxWiDSP5uHWRyMm
✅ Preview: Failed

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #5538 (df40961) into master (fe5290f) will decrease coverage by 3.80%.
The diff coverage is n/a.

❗ Current head df40961 differs from pull request most recent head b66b4c6. Consider uploading reports for the commit b66b4c6 to get more accurate results

@@             Coverage Diff              @@
##             master    #5538      +/-   ##
============================================
- Coverage     71.48%   67.69%   -3.79%     
- Complexity        0      984     +984     
============================================
  Files            96      189      +93     
  Lines          4287     9527    +5240     
  Branches        921     1487     +566     
============================================
+ Hits           3064     6448    +3384     
- Misses         1127     2670    +1543     
- Partials         96      409     +313     

@mikehardy mikehardy merged commit 7a75cb9 into master Jul 21, 2021
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Jul 21, 2021
@mikehardy mikehardy deleted the @mikehardy/dependency-updates branch July 21, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant