Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): fix up auth + perf test platform exclusions, increase dynamic-links e2e testing #5601

Merged
merged 3 commits into from Aug 17, 2021

Conversation

mikehardy
Copy link
Collaborator

Description

Trying very very hard to test some dynamic-link issues, and I was able to increase testing here a lot but not really pinpoint the iOS getInitialLink problems

I believe it will have to run on device to really be a good test, which requires all sorts of setup for Xcode signing etc, and doesn't work with Detox in an automated way.

I may have to handle it like the crash buttons and just setup a couple buttons in the test app so that when installed on a real device testing is still possible

Related issues

Unfortunately - neither of these fixed here - just trying to probe them, not successfully:
#2660 - iOS getInitialLink fails, while Linking.getInitialLink() will return the link for resolution !?
#2631 - on iOS getInitialLink will return same link: open app w/link (correct), background, open again (old link)

Release Summary

Conventional commits

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

The whole thing is tests - however, it's possible that the android e2e test will fail first time, depending on how the deep-link is handled (maybe it opens a chooser? maybe it's possible to auto-associate the chooser to the app, or maybe the test will need to be modified)


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Aug 16, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

react-native-firebase – ./

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/37bZA3mJUCvMFf7f9fs9bAYDLeGP
✅ Preview: https://react-native-firebase-git-mikehardy-remote-config-e2e-invertase.vercel.app

react-native-firebase-next – ./website_modular

🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/2CqY1CqaZc5VzR9mukn2q2jUGzJu
✅ Preview: Canceled

[Deployment for 0ca1434 canceled]

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #5601 (f0ee273) into master (193f5c6) will decrease coverage by 14.04%.
The diff coverage is n/a.

❗ Current head f0ee273 differs from pull request most recent head 0ca1434. Consider uploading reports for the commit 0ca1434 to get more accurate results

@@              Coverage Diff              @@
##             master    #5601       +/-   ##
=============================================
- Coverage     67.73%   53.70%   -14.03%     
+ Complexity      986      614      -372     
=============================================
  Files           202      202               
  Lines          9938     9938               
  Branches       1528     1528               
=============================================
- Hits           6731     5336     -1395     
- Misses         2793     4332     +1539     
+ Partials        414      270      -144     

brianathere
brianathere previously approved these changes Aug 16, 2021
@vercel vercel bot temporarily deployed to Preview – react-native-firebase-next August 17, 2021 14:38 Inactive
@mikehardy mikehardy merged commit f6d57c2 into master Aug 17, 2021
@mikehardy mikehardy deleted the @mikehardy/remote-config-e2e branch August 17, 2021 15:17
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants