Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(messaging, ios): add Background App Refresh / message handler interaction note #6259

Merged
merged 3 commits into from
Jun 24, 2022
Merged

Conversation

roti-c137
Copy link
Contributor

Description

Updated document to include Background App Refresh manual toggle on iOS devices. My understanding is in this scenario, setBackgroundMessageHandler would not trigger and the app will fallback to QUIT state's flow.

Related issues

resolves #5656

Release Summary

Updated document to include Background App Refresh manual toggle on iOS devices.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes. Btw the contributor guide URL is invalid..
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented May 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-native-firebase ✅ Ready (Inspect) Visit Preview Jun 24, 2022 at 10:36PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
react-native-firebase-next ⬜️ Ignored (Inspect) Jun 24, 2022 at 10:36PM (UTC)

@CLAassistant
Copy link

CLAassistant commented May 19, 2022

CLA assistant check
All committers have signed the CLA.

@roti-c137 roti-c137 changed the title Updated document to include Background App Refresh manual toggle on iOS devices. docs: Updated document to include Background App Refresh manual toggle on iOS devices. May 20, 2022
@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Jun 17, 2022
@mikehardy
Copy link
Collaborator

Sorry this has sat so long @roti-c137 ! It looks like a great addition, running it through CI checks now and will do the needful to get it in. Cheers

@roti-c137
Copy link
Contributor Author

I'll need help on the 3 item that is failing...

1 - Spelling & Grammar (attached image), i've already run prettier on that .md file, nothing changes
Screenshot 2022-06-18 at 12 17 30 PM
2 - PR title is conventional - should i make another commit with commit message exactly the same PR title?
Screenshot 2022-06-18 at 12 18 52 PM
3 - Vercel Deployment failed. Showing this
Screenshot 2022-06-18 at 12 27 21 PM

roti-c137 and others added 3 commits June 23, 2022 17:36
Added a short write up on Background App Refresh manual toggle for iOS device. 

My understanding is in this scenario, setBackgroundMessageHandler would not trigger and the app will fallback to QUIT state's flow.
@mikehardy
Copy link
Collaborator

I went through all the items here and rebased it against main then pushed it back to your branch, should work? 🤞

@mikehardy mikehardy changed the title docs: Updated document to include Background App Refresh manual toggle on iOS devices. docs(messaging, ios): add Background App Refresh / message handler interaction note Jun 24, 2022
@mikehardy mikehardy merged commit 4e42d51 into invertase:main Jun 24, 2022
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

messaging.setBackgroundMessageHandler: How to invoke when app is in quit state on iOS
3 participants