Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database): set priority on child snapshot if available #7897

Merged
merged 9 commits into from
Jul 15, 2024

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Jul 12, 2024

Description

Related issues

fixes: #7719

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Jul 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 11:19am

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is not executing all the tests all the time as noted on slack, that's a pretty serious problem as false-positives on the testing are dangerous. I noticed it on this PR since the codecov bot annotated lines as uncovered when a test clearly covered them.

Local testing is passing but we need to find the root cause of CI not executing all tests


        ✔ it should create js apps for natively initialized apps
[🟨] Jet client disconnected - normal closure (code = 1000).
[🟩] Jet client connected from "127.0.0.1:40293".


  18 passing (4s)

@mikehardy mikehardy merged commit 9028ae4 into main Jul 15, 2024
18 of 19 checks passed
@mikehardy mikehardy deleted the database-7719 branch July 15, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🔥] Priority values missing from firebase realtime database DataSnapshot
3 participants