Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move podspec to where "react-native link" expects it to be #838

Closed
wants to merge 1 commit into from

Conversation

mars-lan
Copy link
Contributor

No description provided.

@chrisbianca
Copy link
Contributor

@mars-lan Thanks for this, but we have deliberately not put the podspec here because we want react-native link to link the .xcodeproj file and not the Pod by default.

By using the .xcodeproj file, the process can be completed without user intervention.

If we use the podspec, then the user would have to ensure that React is also installed as a Pod, something that can be difficult to get working.

We have kept the podspec to allow people to use Cocoapods if they wish to.

@mars-lan
Copy link
Contributor Author

Unfortunately react-native link doesn't seem to work well for podspecs outside of project root and keep adding .xcodeproj even after adding pod RNFirebase to Podfile :(

@chrisbianca
Copy link
Contributor

@mars-lan We flagged this with the person that made the change in RN, but unfortunately they have not done anything about it to allow us to configure its usage:

facebook/react-native#15460 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants