This repository has been archived by the owner on Sep 24, 2021. It is now read-only.
fix(android): add react-native 0.65 compatibility event emitter stubs #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikehardy LGTM. thanks for the fix. Will be doing a release tomorrow that can include it :) |
|
had some issues with tests as mentioned on slack but this one works fine :-) - merged it so I can clean the branch and stay focused |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been working through this in a few modules as I test the react-native 0.65 upgrade in a work project in order to fuzz-bust all the libraries
Here's the same in react-native-firebase https://github.com/invertase/react-native-firebase/pull/5616/files#diff-c887076b0c80d540aed1bfbb472cc8f20516634e8e72d53014c65d690bba4fb1
Also did it in netinfo and device-info modules - all seems to be working fine after being released a couple days.
I have this patch already test-integrated in my project via patch-package