Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: transco config destination path example #170

Merged
merged 2 commits into from
Apr 28, 2023
Merged

fix: transco config destination path example #170

merged 2 commits into from
Apr 28, 2023

Conversation

stijnmoreels
Copy link
Collaborator

@stijnmoreels stijnmoreels commented Feb 24, 2023 •
edited
Loading

The Transco configuration model uses the destination JSON member name for the instruction destination, but the example used destinationPath instead.

@stijnmoreels stijnmoreels requested a review from a team as a code owner February 24, 2023 07:07
@matthewpavia99
Copy link
Contributor

Ok for me

@GoutsmitSam GoutsmitSam merged commit 0597a2b into master Apr 28, 2023
6 checks passed
@GoutsmitSam GoutsmitSam deleted the fix/transco-config-destination-path branch April 28, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GoutsmitSam GoutsmitSam GoutsmitSam approved these changes

Assignees

@grik001 grik001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stijnmoreels @matthewpavia99 @GoutsmitSam @grik001