Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 Feature - add multiple tracking properties #40

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stijnmoreels
Copy link
Contributor

Relates to #33

@stijnmoreels stijnmoreels marked this pull request as ready for review June 17, 2020 06:11
@stijnmoreels
Copy link
Contributor Author

Requires an update of the Logic App definition (I think) to write positive tests that include multiple tracking properties, @mbraekman ?

Copy link
Contributor

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Happy test like you suggested would be ideal indeed!

@mbraekman
Copy link
Contributor

Currently the TestLogicApp allows for the promotion of 1 tracked property:

  • name: trackedproperty

Yes, we should update the logic app to support multiple tracked properties.
I'd like to update the invictus-tst-we-rcv-trigger-http logic app and have it replace the TestLogicApp, mainly to resolve the bad naming convention used.

Purpose should be:

  • promote some default tracked properties from within the Logic App
  • allow the user to provide a list of properties to become tracked properties - with dynamically defined names, instead of trackedproperty1, trackedproperty2, ...

I'll assign this to myself to create a proper Logic App to be used for this, unless anyone else wants to do this of course :)

@mbraekman mbraekman self-assigned this Jun 18, 2020
@stijnmoreels stijnmoreels linked an issue Jun 23, 2020 that may be closed by this pull request
@tomkerkhove
Copy link
Contributor

This was finished, right @mbraekman or did I misread this somewhere else?

@mbraekman
Copy link
Contributor

@tomkerkhove, not yet - a different logic app has been created to be used for the Update/Run-tests, but it didn't support multiple tracking properties yet. So, still in progress.

@tomkerkhove
Copy link
Contributor

No worries!

@stijnmoreels stijnmoreels marked this pull request as draft July 29, 2020 12:46
@stijnmoreels stijnmoreels changed the title Feature - add multiple tracking properties 🚧 Feature - add multiple tracking properties Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide multiple tracking properties
3 participants