-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded to go 1.17 #11
Conversation
Notes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nits, overall LGTM. Thanks for contribution!
I've opened #12 to fix some basic stuff, let's wait for it to be merged before we merge this one. |
#12 is now merged. |
4c7a619
to
cf09bfa
Compare
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
=======================================
Coverage 75.75% 75.75%
=======================================
Files 2 2
Lines 99 99
=======================================
Hits 75 75
Misses 12 12
Partials 12 12 Continue to review full report at Codecov.
|
Signed-off-by: Sergei Ivanov <sergei_ivanov@mail.ru>
cf09bfa
to
41e25b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this should be ready now. Hopefully the build passes this time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Shall I merge @sergei-ivanov?
Yes please. Let's cut a new release, in order to unblock my colleagues on new shiny Macs. And after that we can start working on further improvements. |
Thanks for help again. It's late today, I'll add some changelog and wrap a release tomorrow. |
Upgraded go dependencies
Fixes #10
Signed-off-by: Sergei Ivanov sergei_ivanov@mail.ru