Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to go 1.17 #11

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Conversation

sergei-ivanov
Copy link
Contributor

@sergei-ivanov sergei-ivanov commented Jan 30, 2022

Upgraded go dependencies
Fixes #10

Signed-off-by: Sergei Ivanov sergei_ivanov@mail.ru

@sergei-ivanov
Copy link
Contributor Author

sergei-ivanov commented Jan 30, 2022

Notes:

  1. I haven't updated the changelog / release notes, because I am not sure how they are maintained in this project.
  2. The latest version of golangci-lint throws a few new errors when run via Makefile, but they seem to be unimportant, and I did not fix them. Mostly because I have a 99% ready branch with a major refactoring for Migrate to Terraform SDK v2 #8 and I'll probably address some of them there.
  3. One outstanding linting issue concerns deprecation of golang.org/x/crypto. We may need to look for a supported alternative (there are forks by ProtonMail and Keybase). Probably should be addressed as part of Add support for ed25519 keys #9

Copy link
Owner

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits, overall LGTM. Thanks for contribution!

README.md Outdated Show resolved Hide resolved
.tool-versions Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
@invidian
Copy link
Owner

I've opened #12 to fix some basic stuff, let's wait for it to be merged before we merge this one.

@invidian
Copy link
Owner

invidian commented Feb 1, 2022

#12 is now merged.

@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #11 (41e25b7) into master (7efaa45) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #11   +/-   ##
=======================================
  Coverage   75.75%   75.75%           
=======================================
  Files           2        2           
  Lines          99       99           
=======================================
  Hits           75       75           
  Misses         12       12           
  Partials       12       12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7efaa45...41e25b7. Read the comment docs.

Signed-off-by: Sergei Ivanov <sergei_ivanov@mail.ru>
Copy link
Contributor Author

@sergei-ivanov sergei-ivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this should be ready now. Hopefully the build passes this time.

go.mod Show resolved Hide resolved
Copy link
Owner

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Shall I merge @sergei-ivanov?

@sergei-ivanov
Copy link
Contributor Author

LGTM. Shall I merge @sergei-ivanov?

Yes please. Let's cut a new release, in order to unblock my colleagues on new shiny Macs. And after that we can start working on further improvements.

@invidian invidian merged commit f74f1dc into invidian:master Feb 1, 2022
@invidian
Copy link
Owner

invidian commented Feb 1, 2022

Thanks for help again. It's late today, I'll add some changelog and wrap a release tomorrow.

@sergei-ivanov sergei-ivanov deleted the upgrade-go-1.17 branch February 1, 2022 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for darwin-arm64 in further releases
2 participants