Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak existing Unicode tests, add a Unicode version test #212

Merged
merged 4 commits into from
Nov 28, 2023

Conversation

cmsmcq
Copy link
Contributor

@cmsmcq cmsmcq commented Nov 17, 2023

This pull request

  • Adds a dependency flag to the existing 'unicode-classes' test case, specifying that it requires Unicode 14.0 or higher.
  • Adds a unicode-version-check test set with a grammar and input that should produce output identifying the version of Unicode used by the ixml processor. This test set is intended to cover Unicode versions 6.0 through 15.1.
  • Renames the existing unicode-range1 test case in the unicode-range2 test set as unicode-range2. The existing name is not an error (test case names only have to be unique within a test set) but it seemed unnecessarily confusing.

Currently MarkupBlitz passes the new test, as does jwiXML (if the grammar is modified to work around lack of support for . as a name character); both return a result of Unicode 15.0. Coffeepot rejects the input in a way I don't understand (which may reflect an issue with the encoding of the input); ixample returns an empty result. From the mixture of successful runs and failures, it appears there may be an issue with the test input or test grammar, but I think the easiest way to find such an issue is to check the test in so more people can run it.

Copy link
Contributor

@ndw ndw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be a fair number of descrepancies between what the tests think the files are called and what the files are actually called:

  • There seems to be a general problem that the tests refer to unicode-v... where the files are named unicode.v....
  • Additionally some (but not all) of the versions less than 10 expect the filename to have a leading zero where they do not (e.g., unicode-v06... vs. unicode-v6...

@cmsmcq cmsmcq requested a review from ndw November 22, 2023 03:06
@cmsmcq
Copy link
Contributor Author

cmsmcq commented Nov 22, 2023

OK, I've tried to sync them correctly, but at this point of the evening I don't trust my eyes, so I'm asking for another review from you.

I'm also troubled by the fact that href-check.xsl is reporting that it cannot find unicode-classes.inp, which seems to contradict the evidence of ls.

@spemberton
Copy link
Member

spemberton commented Nov 22, 2023 via email

@cmsmcq
Copy link
Contributor Author

cmsmcq commented Nov 22, 2023

The commit labeled Add tests for shared nullable prefixes, adjust unicode version test adds a separate test set for shared nullable prefixes and changes s in the unicode-version-diagnostic grammar to be non-nullable.

@spemberton
Copy link
Member

spemberton commented Nov 22, 2023 via email

@cmsmcq cmsmcq merged commit 942c016 into invisibleXML:master Nov 28, 2023
2 checks passed
@cmsmcq cmsmcq deleted the more-metadata branch November 28, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants