Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small test catalog update #218

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Small test catalog update #218

merged 1 commit into from
Nov 28, 2023

Conversation

ndw
Copy link
Contributor

@ndw ndw commented Nov 25, 2023

A grammar-test can include app-info which results in multiple grammar tests for the same test-set. (See, for example, multi-1 in tests/grammar-misc.) To represent this in the report, it's necessary to allow multiple grammar-result* instead of grammar-result?.

Also updated the rng version of the schema.

@ndw ndw requested a review from cmsmcq November 25, 2023 15:19
@cmsmcq
Copy link
Contributor

cmsmcq commented Nov 26, 2023

Looks good at first glance. But if we ever end up with dependencies or options affecting a grammar test, we may also need to allow grammar-test to repeat, in the catalog. But for now, sufficient unto the day is the evil thereof.

I say, go.

Copy link
Contributor

@cmsmcq cmsmcq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeating last comment (which Github did not realize was a review). Looks good to me.

@ndw ndw merged commit 6a589f2 into invisibleXML:master Nov 28, 2023
2 checks passed
@ndw ndw deleted the test-cat branch November 28, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants