Fix to issue #1109 regarding Webbrowser #1110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when desctruction of WebBrowserProcessor occurs..
|
|
ResearchDaniel
requested changes
Feb 16, 2021
| WebBrowserClient* webbrowser = | ||
| static_cast<WebBrowserClient*>(browser_->GetHost()->GetClient().get()); | ||
| webbrowser->removeLoadHandler(this); | ||
| webbrowser->OnBeforeClose(browser_); |
There was a problem hiding this comment.
I don't think that this is a solution to the problem. From the docs of close_browser:
"Results in a call to cef_life_span_handler_t::do_close() if the event handler allows the close or if |force_close| is true (1)"
There was a problem hiding this comment.
If the code above resolves the issue we might want to look into handling browser destruction in WebBrowserClient::OnBeforeClose
…ctive when you load another workspace.
| @@ -141,13 +141,13 @@ bool WebBrowserClient::DoClose(CefRefPtr<CefBrowser> browser) { | |||
| void WebBrowserClient::OnBeforeClose(CefRefPtr<CefBrowser> browser) { | |||
| CEF_REQUIRE_UI_THREAD(); | |||
| auto bdIt = browserParents_.find(browser->GetIdentifier()); | |||
| if (bdIt != browserParents_.end()) { | |||
| if (bdIt != browserParents_.end() && messageRouter_) { | |||
There was a problem hiding this comment.
This is caused by a bug you introduced with your other fix :)
|
See PR #1115 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1109