Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we depricate getAsDouble and similar methods #814

Open
r-englund opened this issue Dec 16, 2019 · 1 comment
Open

Should we depricate getAsDouble and similar methods #814

r-englund opened this issue Dec 16, 2019 · 1 comment

Comments

@r-englund
Copy link
Member

The use of getAsDouble is a quite non-optimal way of accessing data and should be avoided.
I often see code where it is used as a primary way to access the data, often in loops.

Should we mark them as deprecated such that we can remove them in the future? The depreciation message could point to documentation on how to efficiently access data.

@PetiteViking
Copy link
Contributor

I'm all for marking them as deprecated and pointing developers to a better way of doing it but I will also say that back when I first started off with Inviwo, those methods saved my life.

It's not the best way of doing things but these methods allow you to easily get things done when you just get into Inviwo. It's a steep learning curve and I feel like they offer some stepping stone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants