Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email Templates and Reminders #606

Closed
JackDAce opened this issue Nov 10, 2023 · 6 comments
Closed

Email Templates and Reminders #606

JackDAce opened this issue Nov 10, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@JackDAce
Copy link

JackDAce commented Nov 10, 2023 •
edited

Setup

  • Version: v5.7.46-W138
  • Environment: Shared Hosting

Interface

  • Flutter: [X]
  • React: []
  • Both: []

Checklist

  • Can you replicate the issue on our v5 demo site https://demo.invoiceninja.com or https://react.invoicing.co/demo? Yes, put < html ></ html > then click Design. the loading will get stuck.
  • Have you searched existing issues?
  • Have you reported this to Slack/forum before posting?
  • Have you inspected the logs in storage/logs/laravel.log for any errors? Yes, no errors.

Describe the bug

All working with my v5.7.15. However, upon updating to the latest version, I can no longer send invoice/quote emails when clicking the "Send Email" button. I tried to check my Laravel log and my PHP log (with DEBUG=True in my env) for any possible errors but can't find anything. Out of curiosity, I tried to remove my customized template and just put a normal div tag, and the abnormal behavior is gone. I also would like to add that this abnormal behavior only happens when I'm using Invoice Ninja via the Desktop and Browser. I never experienced the problem on the mobile app.

Steps To Reproduce

Yes, put < html ></ html > then click Design. the loading will get stuck.

Expected Behavior

To accept HTML tags for email customization under Templates and Reminders.

Additional context

Screenshots

Logs
@turbo124
Copy link
Member

@JackDAce this seems localized to demo.invoiceninja.com rather than react.invoicing.co right?

ping @hillelcoren

@JackDAce
Copy link
Author

@turbo124 Yes

@hillelcoren hillelcoren transferred this issue from invoiceninja/invoiceninja Nov 11, 2023
@hillelcoren
Copy link
Member

Can you please share an email template we can use to reproduce the problem?

@hillelcoren hillelcoren added bug Something isn't working and removed more info requested triage labels Nov 11, 2023
@JackDAce
Copy link
Author

Hi @hillelcoren ,

Please see the sample template.

<html>
<body>
<h1>Dear $contact.first_name,</h1>
<p>A new invoice with reference # $number has been generated, kindly see attached file. For any concern(s), feel free to reach out.</p>
</body>
</html>

@hillelcoren
Copy link
Member

Thanks for the sample!

Is "Enable email markdown" enabled on Settings > Account Management/does disabling the option help?

@JackDAce
Copy link
Author

Thanks for the quick workaround solution!

I disabled "Enable email markdown" and everything is working now.

hillelcoren added a commit that referenced this issue Nov 12, 2023
@hillelcoren
Email Templates and Reminders #606
e0f6fbd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hillelcoren @turbo124 @JackDAce