Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currency unit after amount #109

Closed
erikmoren opened this issue May 1, 2014 · 1 comment
Closed

Currency unit after amount #109

erikmoren opened this issue May 1, 2014 · 1 comment

Comments

@erikmoren
Copy link

Hey,

I've been tinkering with the code a bit. Tried to implement swedish language and currency. Realized the currency unit is displayed after the amount, instead of before. Like this: "kr 123", instead of how we (most often) do it in Sweden: "123 kr".

Is it difficult to implement?

Interested in swedish translation? I have no experience in doing pull requests, but I think I can manage.

Thanks for a cool web app anyway.

Regards
Erik

@hillelcoren
Copy link
Member

Hi, thanks for your interest in the project.

  • Moving the currency symbol is doable but not-trivial. I'd be happy to help if you'd like to implement the feature. We store the list of currencies in a table called (unsurprisingly) currencies. You'd need to add a symbol_position field. Also note this data is cached, if you change it you'd need to un-comment Cache::flush(); in routes.php and load the page.
  • Supporting Swedish would be great. If you decide to work on it please use https://github.com/caouecs/Laravel4-lang for the starter files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants