Can't login into client portal because a password is required after upgrade invoiceninja

[PeopleInside]

As described here:
#1544

I can only add after upgrade invoice ninja if I try to access to the customer portal a password is required also if I AM sign in from the admin interface... so I have to remove the password or I cannot see client portal.

I would happy on see this resolved.

[PeopleInside]

Issue is if I login by incognito mode in Firefox.
Is not the incognito mode of Firefox as if I open Chrome and login as admin and than use view client portal a password to see the client portal is required. I do not know the password so I cannot see...

[hillelcoren]

When using incognito you'll need to use the password as the app won't see that you're logged in.

[PeopleInside]

I log-in as admin in incognito mode so I AM logged.. in the admin, I press the link to see the client portal and not work asking password.
Usually I use Firefox so I tried with Chrome without incognito and is the same. I cannot see client portal as a password is required.

[PeopleInside]

Maybe a fix can be to be able to see the password as this is generated by the system but there is no show password function.
I want see this resolved in some way, please. I cannot reset password or remove password...

[hillelcoren]

Does it work if you aren't using incognito mode?

[PeopleInside]

Well works on Firefox where I was already logged in. If I open Chrome where I was not logged IN and I log-in as Admin than I try to see customer area I AM unable because a customer password is required.

But also if I log in as admin in the incognito mode I should be able to log in into the client portal... or maybe really need a function to show the password so I can digit it and log in into the client area.

[hillelcoren]

It's helpful to know it works in Firefox but not Chrome. It's worth checking that 'Block third party cookies' is disabled on Settings > Show Advanced > Content Settings.

We use a one way encryption to store the passwords.

[PeopleInside]

@hillelcoren I think the issue is same in Chrome as in Firefox. If you use Firefox as Incognito and you log in as admin you should be able to see client portal. Well is not working is asking client portal password.

[hillelcoren]

I'm not sure, without being able to replicate the problem it will be hard for me to help.

[PeopleInside]

Sure @hillelcoren ,
can you try to create a customer, set invoice with password than try to see client portal.
Try now to login into the admin by incognito mode than click on see customer portal. Are you able to see?

I upgraded today your software so I was using the incognito mode as my browser is showing old version (cached version) and seems if I use a clean browser I AM not able to see the client portal from the admin panel in the customer tab where there is direct link (admin) to see client portal.
Sound to me as a BUG.

[hillelcoren]

I've tried to replicate the problem however it works correctly in my tests.

[PeopleInside]

Can I show to you the issue by remote control?
I want understand why there are this issue and how to fix.

So you can diagnostics if is a bug as I think.

[hillelcoren]

If you want you can email a screencast to contact@invoiceninja.com

[PeopleInside]

I will do :)
Thanks

[PeopleInside]

Before send an email can you try please this:

• Activate invoice password
• Create a test customer
• Create an invoice
• Send the invoice by email (email should have listed the password if you see the password in the email means the password has been generated and is active
• Open a incognito window on Firefox
• Login into ninja as admin
• Open customer and press view client customer portal.
  You will be asked to insert customer password. This is the issue, I never have customer password.

I create a test user and follow this step I AM able to replicate the issue

[PeopleInside]

Seems the fix found by you works

Can you try changing line 71 in app/Http/Middleware/Authenticate.php from

if (Auth::guard('user')->check() && Auth::user('user')->account_id === $account->id) {

To

if (Auth::guard('user')->check() && Auth::user('user')->account_id == $account->id) {

[PeopleInside]

Issue not solved, issue come back again after the last update.