Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes for send reminders #8391

Merged
merged 4 commits into from
Mar 20, 2023
Merged

Conversation

turbo124
Copy link
Member

No description provided.

dependabot bot and others added 4 commits February 3, 2023 11:26
Bumps [symfony/http-kernel](https://github.com/symfony/http-kernel) from 4.4.43 to 4.4.50.
- [Release notes](https://github.com/symfony/http-kernel/releases)
- [Changelog](https://github.com/symfony/http-kernel/blob/6.2/CHANGELOG.md)
- [Commits](symfony/http-kernel@v4.4.43...v4.4.50)

---
updated-dependencies:
- dependency-name: symfony/http-kernel
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@turbo124 turbo124 merged commit 51133b2 into invoiceninja:master Mar 20, 2023
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ turbo124
❌ dependabot[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

@blazerunner44 blazerunner44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@turbo124 Can you confirm this is an issue on your end as well? This change prevented me from sending invoice emails manually.

@@ -34,7 +34,7 @@

$app = require_once __DIR__.'/../bootstrap/app.php';

// require_once __DIR__.'/../app/Constants.php';
require_once __DIR__.'/../app/Constants.php';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change breaks the constants throughout the app for me. The Constants.php file loads via the env() helper method and at this point in the Laravel application lifecycle, the env values aren't available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants