Database migration fails with v5.7.3 "Expression could not be converted to string"

[nebulade]

Given that v5.7.1 and v5.7.2 have no release assets, it's a bit hard for me to bisect the changes, but really it seems hardlyu anything has changed, and I am not sure what that laravel change there is: v5.7.0...v5.7.3

Either way while testing a new Cloudron package for 5.7.3 we hit a database migration issue at https://github.com/invoiceninja/invoiceninja/blob/v5-stable/database/migrations/2022_10_05_205645_add_indexes_to_client_hash.php#L16C58-L16C58

So other index creations work fine but the DB::raw() type does not seem to be supported suddenly? Changing those to normal index names works as expected. The blueprint stacktrace is and indeed I can't see how the indexName creation would have worked looking at the blueprint code in those sections:

   INFO  Running migrations.  

  2022_10_05_205645_add_indexes_to_client_hash ............................................................................................ 1ms FAIL

In Blueprint.php line 1682:
                                                                                         
  [Error]                                                                                
  Object of class Illuminate\Database\Query\Expression could not be converted to string  
                                                                                         

Exception trace:
  at /app/code/vendor/laravel/framework/src/Illuminate/Database/Schema/Blueprint.php:1682
 implode() at /app/code/vendor/laravel/framework/src/Illuminate/Database/Schema/Blueprint.php:1682
 Illuminate\Database\Schema\Blueprint->createIndexName() at /app/code/vendor/laravel/framework/src/Illuminate/Database/Schema/Blueprint.php:1644
 Illuminate\Database\Schema\Blueprint->indexCommand() at /app/code/vendor/laravel/framework/src/Illuminate/Database/Schema/Blueprint.php:581
 Illuminate\Database\Schema\Blueprint->index() at /app/code/database/migrations/2022_10_05_205645_add_indexes_to_client_hash.php:16
 Illuminate\Database\Migrations\Migration@anonymous\/app/code/database/migrations/2022_10_05_205645_add_indexes_to_client_hash.php:7$1a0->{closure}() at /app/code/vendor/laravel/framework/src/Illuminate/Database/Schema/Blueprint.php:96
 Illuminate\Database\Schema\Blueprint->__construct() at n/a:n/a

[turbo124]

Thanks for reporting this.

Fix checked in here #8746

And v5.7.4 has now been tagged

[nebulade]

Great! Thanks for the super fast fix. I can confirm its working as expected.