Emails sent by scheduler are sent as next reminder template

[shurushetr]

Setup

• Version: v5.8.9-C148
• Environment: docker

Interface

• Flutter: []
• React: [V]
• Both: []

Checklist

• Can you replicate the issue on our v5 demo site https://demo.invoiceninja.com or https://react.invoicing.co/demo?
• N/A
• Have you searched existing issues?
• Yes
• Have you reported this to Slack/forum before posting?
• Yes - https://forum.invoiceninja.com/t/emails-second-email-sent-with-schedule-as-a-reminder/15026
• Have you inspected the logs in storage/logs/laravel.log for any errors?
• N/A

Describe the bug

If I hit send email button, and email goes through - customer receives an email - as “Initial email” (if this is the template I’ve selected)
But then next day (according to schedule in the system settings) email get’s send as a first reminder again - and this is really annoying for clients =)

Steps To Reproduce

Set send time in Settings => Email Settings => Send Time
Send an email with invoice/quote manually after creating the invoice/quote.
Wait for the set time in the settings
Second email will go out, as a second reminder template.

Expected Behavior

Don't send automatic second email at all if it was already sent by a user. Avoid creating duplicates.

Additional context

Clients receive one email with invoice, and then next day in the morning, another but with reminder - payment is not received yet - this is very annoying for customers who have NET30 or other terms.

Screenshots

Logs

[turbo124]

The system is designed to calculate the next applicable email template. If you want the initial email to send, you'll want to leave the invoice in a draft state.

[shurushetr]

Wait what?
Does this mean if I leave a bunch of half baked invoices in draft state, system will dispatch them via email automatically? (no scheduler setup, only the time set in the "email settings" section)???

This is not clearly stated in the lifecycle

[turbo124]

@shurushetr

Run this test:

1. Create an invoice.
2. Leave it in a draft state
3. Schedule the invoice to send at some time in the future

The result should be that the initial template is used when sending the email.

[shurushetr]

I get that draft is going to be emailed. I'm so glad I never left a draft to hang around for a while.

My understanding was that if it is a draft - it is not ready. Especially not ready to be emailed to client. This makes sense in every other system. Am I alone in this?
Regardless, there shoudn't be a confusion created when system automatically sends invoice (again, there is no scheduler setup, only in the email settings - set time, that is non removable).

If the DRAFT document will be automatically dispatched, it shouldn't be called draft at the very least... "Ready for dispatch" or something.

Thanks for closing the ticket on a weekend, I don't think it should've been :)