Documents marked "Sent" even when email failed to be dispatched by Invoice Ninja.

[shurushetr]

Setup

• Version: v5.8.26-C155
• Environment: Docker

Interface

• Flutter: []
• React: []
• Both: [V]

Checklist

• Can you replicate the issue on our v5 demo site https://demo.invoiceninja.com or https://react.invoicing.co/demo? - Yes
• Have you searched existing issues? - Yes
• Have you reported this to Slack/forum before posting? - Yes - https://forum.invoiceninja.com/t/failed-email-notification/15025
• Have you inspected the logs in storage/logs/laravel.log for any errors? - Yes.

Describe the bug

Invoices/Quotes and other emailed items are being marked as "Sent" even if they weren't actually sent and logs have records of failed emails. Confusing user experience and creating not needed follow up calls with clients about invoice not being paid, or quotes not viewed for example.

Steps To Reproduce

Send any email within Invoice Ninja with faulty email server config - dispatch will fail but the document will be marked as "Sent"

Expected Behavior

When email dispatch failed - change status of the document to "Failed to email" or something similar.

Additional context

Would be great to have logs showing what had failed to email - without it, significant amount of time wasted in search of a document with problems.

Screenshots

Logs

[turbo124]

Once an invoice is committed to being "sent" the balance increments to the amount owing. This defines the status change from "Draft" to "Sent".

Perhaps sent isn't the best terminology in cases where the email fails to send,