Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small transactions below integer value 1 (lets say 0.99 cents) become a debit instead of credit #9536

Closed
yannickboy15 opened this issue May 21, 2024 · 1 comment

Comments

@yannickboy15
Copy link
Contributor

yannickboy15 commented May 21, 2024

Setup

  • Version: V5-stable
  • Environment: Shared Hosting

Interface

  • Flutter: []
  • React: []
  • Both: [X]

Checklist

Describe the bug

Here you see that values are casted to an integer. I was debugging how transaction rules worked and tried it with transactions of 0.01 cents (E2E testing). I somehow noticed that all those payments were set as a withdrawal, while those are obviously credit transactions. I tried transferring money over 1 euro and it worked fine. Now it's an edge case but it was really weird, especially as I am trying to work out transaction rules. I'm using GoCardless for this, as that's the only way I can get my transactions in IN.

Steps To Reproduce

Hook up your instance to GoCardless. Transfer money that is below 1 to your linked account. You'll notice that it says withdrawal instead of payment.

Expected Behavior

I'm expecting that all transactions that are positive > 0 are payments.

Additional context

Screenshots

firefox_kudPSNwNV0

Logs


@yannickboy15
Copy link
Contributor Author

Made a fix for this (I assume that's where the UI fetches the data from, old transactions would remain like this due to database compatibility): #9537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants