[bug]: Width and Height change on switching 1.5 models #5452
Labels
Comments
TheCulprit
changed the title
|
@psychedelicious - I think the issue here that violates User expectations is that we're switching W/H on 'same model architecture' and "optimizing" something that's technically valid in user's mind. Rather than try to do weird things w/ optimization calc, I'd wager just "only resetting sizes if switching architectures" would solve the problems. Alternatively, could revert our last change, but I think the above is the "ideal". |
psychedelicious
added a commit
that referenced
this issue
Jan 9, 2024
… base model There's a challenge to accomplish this due to our slice structure - the model is stored in `generationSlice`, but `canvasSlice` also needs to have awareness of it. For example, when the model changes, the canvas slice doesn't know what the previous model was, so it doesn't know whether or not to optimize the size. This means we need to lift the "should we optimize size" information up. To do this, the `modelChanged` action creator accepts the previous model as an optional second arg. Now the canvas has access to both the previous model and new model selection, and can decide whether or not it should optimize its size setting in the same way that the generation slice does. Closes #5452
hipsterusername
pushed a commit
that referenced
this issue
Jan 10, 2024
… base model There's a challenge to accomplish this due to our slice structure - the model is stored in `generationSlice`, but `canvasSlice` also needs to have awareness of it. For example, when the model changes, the canvas slice doesn't know what the previous model was, so it doesn't know whether or not to optimize the size. This means we need to lift the "should we optimize size" information up. To do this, the `modelChanged` action creator accepts the previous model as an optional second arg. Now the canvas has access to both the previous model and new model selection, and can decide whether or not it should optimize its size setting in the same way that the generation slice does. Closes #5452
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for this?
OS
Windows
GPU
cuda
VRAM
No response
What version did you experience this issue on?
3.6.0rc5
What happened?
When using a 1.5 model, if the width/height boxes are set to anything other than 512x512 then on switching to another 1.5 model the sizes will change. This only seems to apply the t2i and i2i tabs. The UC is unaffected.
Sizes change when switching from 1.5 to XL models seems to work as intended however switching back results in the same errors in the sizing.
When switching from a 1.5 model at 512x768 to another 1.5 model the size ends up at 416x624
When switching from a 1.5 model at 512x768 to an XL model the size ends up at 840x1256.
Switching back to a 1.5 model and the size ends up at 416x624 again.
Same behaviour in Chrome and Firefox.
Screenshots
No response
Additional context
No response
Contact Details
Stretch (villainstretch) on Discord
The text was updated successfully, but these errors were encountered: